From: Johan Hovold <johan@kernel.org>
To: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Support Opensource <support.opensource@diasemi.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Milo Kim <milo.kim@ti.com>,
patches@opensource.wolfsonmicro.com,
Fabio Estevam <fabio.estevam@freescale.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe
Date: Tue, 14 Apr 2015 15:04:06 +0200 [thread overview]
Message-ID: <20150414130406.GA26326@localhost> (raw)
In-Reply-To: <20150326083209.GE5951@x1>
Hi Mark and Lee,
On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote:
> On Wed, 25 Mar 2015, Johan Hovold wrote:
>
> > Fix broken probe of da9052 regulators, which since commit b3f6c73db732
> > ("mfd: da9052-core: Fix platform-device id collision") use a
> > non-deterministic platform-device id to retrieve static regulator
> > information. Fortunately, adequate error handling was in place so probe
> > would simply fail with an error message.
> >
> > Update the mfd-cell ids to be zero-based and use those to identify the
> > cells when probing the regulator devices.
> >
> > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision")
> > Cc: stable <stable@vger.kernel.org> # v3.19
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > drivers/mfd/da9052-core.c | 8 ++++----
> > drivers/regulator/da9052-regulator.c | 5 +++--
>
> Need an Ack from Mark, but looks good to me.
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Mark, did you have a chance to look at this one?
It fixes a regression due to an mfd commit, but not sure who of you that
wants to take it.
Thanks,
Johan
next prev parent reply other threads:[~2015-04-14 13:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150325110231.GC10412@localhost>
2015-03-25 11:07 ` [PATCH 1/2] mfd: da9052: fix broken regulator probe Johan Hovold
2015-03-25 11:07 ` [PATCH 2/2] mfd: core: fix platform-device name collisions Johan Hovold
2015-03-25 12:02 ` Bartlomiej Zolnierkiewicz
2015-03-26 8:34 ` Lee Jones
2015-03-25 12:01 ` [PATCH 1/2] mfd: da9052: fix broken regulator probe Bartlomiej Zolnierkiewicz
2015-03-26 8:32 ` Lee Jones
2015-04-14 13:04 ` Johan Hovold [this message]
2015-04-29 7:44 ` Johan Hovold
2015-04-29 8:41 ` Lee Jones
2015-05-13 15:43 ` Lee Jones
2015-05-13 16:08 ` Mark Brown
2015-05-13 16:54 ` Lee Jones
2015-05-13 17:29 ` Mark Brown
2015-05-14 7:19 ` Lee Jones
2015-05-15 14:47 ` Johan Hovold
2015-05-18 9:10 ` Lee Jones
2015-05-18 9:51 ` Johan Hovold
2015-05-18 10:13 ` Lee Jones
2015-05-18 16:28 ` Mark Brown
2015-05-18 16:24 ` Mark Brown
2015-05-18 16:46 ` Johan Hovold
2015-05-18 18:46 ` Mark Brown
2015-05-19 10:01 ` Johan Hovold
2015-05-19 10:38 ` Mark Brown
2015-05-19 11:01 ` Johan Hovold
2015-05-19 12:01 ` Mark Brown
2015-05-15 14:27 ` [PATCH RESEND] " Johan Hovold
2015-05-18 18:47 ` Mark Brown
2015-05-18 18:57 ` Lee Jones
2015-03-30 7:18 ` [PATCH 1/2] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414130406.GA26326@localhost \
--to=johan@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=milo.kim@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).