From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 14 Apr 2015 15:04:06 +0200 From: Johan Hovold To: Lee Jones , Mark Brown Cc: Johan Hovold , Support Opensource , Samuel Ortiz , Liam Girdwood , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Milo Kim , patches@opensource.wolfsonmicro.com, Fabio Estevam , Marek Szyprowski , stable Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe Message-ID: <20150414130406.GA26326@localhost> References: <20150325110231.GC10412@localhost> <1427281625-31241-1-git-send-email-johan@kernel.org> <20150326083209.GE5951@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150326083209.GE5951@x1> Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Mark and Lee, On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote: > On Wed, 25 Mar 2015, Johan Hovold wrote: > > > Fix broken probe of da9052 regulators, which since commit b3f6c73db732 > > ("mfd: da9052-core: Fix platform-device id collision") use a > > non-deterministic platform-device id to retrieve static regulator > > information. Fortunately, adequate error handling was in place so probe > > would simply fail with an error message. > > > > Update the mfd-cell ids to be zero-based and use those to identify the > > cells when probing the regulator devices. > > > > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision") > > Cc: stable # v3.19 > > Signed-off-by: Johan Hovold > > --- > > drivers/mfd/da9052-core.c | 8 ++++---- > > drivers/regulator/da9052-regulator.c | 5 +++-- > > Need an Ack from Mark, but looks good to me. > > Acked-by: Lee Jones Mark, did you have a chance to look at this one? It fixes a regression due to an mfd commit, but not sure who of you that wants to take it. Thanks, Johan