* [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed
@ 2015-04-24 23:33 K. Y. Srinivasan
2015-04-25 7:05 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: K. Y. Srinivasan @ 2015-04-24 23:33 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, ohering, jbottomley, hch, linux-scsi,
apw, vkuznets, jasowang
Cc: K. Y. Srinivasan, stable
Set the SRB flags correctly when there is no data transfer.
Cc: <stable@vger.kernel.org>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
---
drivers/scsi/storvsc_drv.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index d9dad90..3c6584f 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1600,8 +1600,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
break;
default:
vm_srb->data_in = UNKNOWN_TYPE;
- vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN |
- SRB_FLAGS_DATA_OUT);
+ vm_srb->win8_extension.srb_flags |= SRB_FLAGS_NO_DATA_TRANSFER;
break;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed
@ 2015-04-25 0:23 K. Y. Srinivasan
2015-05-11 9:10 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: K. Y. Srinivasan @ 2015-04-25 0:23 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, ohering, jbottomley, hch, linux-scsi,
apw, vkuznets, jasowang
Cc: K. Y. Srinivasan, stable
Set the SRB flags correctly when there is no data transfer.
Cc: <stable@vger.kernel.org>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
---
drivers/scsi/storvsc_drv.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index d9dad90..3c6584f 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1600,8 +1600,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
break;
default:
vm_srb->data_in = UNKNOWN_TYPE;
- vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN |
- SRB_FLAGS_DATA_OUT);
+ vm_srb->win8_extension.srb_flags |= SRB_FLAGS_NO_DATA_TRANSFER;
break;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed
2015-04-24 23:33 [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed K. Y. Srinivasan
@ 2015-04-25 7:05 ` Dan Carpenter
2015-04-25 16:15 ` KY Srinivasan
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2015-04-25 7:05 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: gregkh, linux-kernel, devel, ohering, jbottomley, hch, linux-scsi,
apw, vkuznets, jasowang, stable
On Fri, Apr 24, 2015 at 04:33:55PM -0700, K. Y. Srinivasan wrote:
> Set the SRB flags correctly when there is no data transfer.
>
What are the user visible effects of this bug? We transfer bogus data?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed
2015-04-25 7:05 ` Dan Carpenter
@ 2015-04-25 16:15 ` KY Srinivasan
0 siblings, 0 replies; 5+ messages in thread
From: KY Srinivasan @ 2015-04-25 16:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, ohering@suse.com,
jbottomley@parallels.com, hch@infradead.org,
linux-scsi@vger.kernel.org, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com, stable@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, April 25, 2015 12:05 AM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; ohering@suse.com;
> jbottomley@parallels.com; hch@infradead.org; linux-scsi@vger.kernel.org;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> stable@vger.kernel.org
> Subject: Re: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no
> data transfer is needed
>
> On Fri, Apr 24, 2015 at 04:33:55PM -0700, K. Y. Srinivasan wrote:
> > Set the SRB flags correctly when there is no data transfer.
> >
>
> What are the user visible effects of this bug? We transfer bogus data?
No, we don't transfer any bogus data. However, some IHV drivers will
return an error on some valid commands because of these flags being set.
Regards,
K. Y
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed
2015-04-25 0:23 K. Y. Srinivasan
@ 2015-05-11 9:10 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2015-05-11 9:10 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: gregkh, linux-kernel, devel, ohering, jbottomley, hch, linux-scsi,
apw, vkuznets, jasowang, stable
On Fri, Apr 24, 2015 at 05:23:23PM -0700, K. Y. Srinivasan wrote:
> Set the SRB flags correctly when there is no data transfer.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-11 9:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-24 23:33 [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed K. Y. Srinivasan
2015-04-25 7:05 ` Dan Carpenter
2015-04-25 16:15 ` KY Srinivasan
-- strict thread matches above, loose matches on Subject: below --
2015-04-25 0:23 K. Y. Srinivasan
2015-05-11 9:10 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).