From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39498 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbbDZKV3 (ORCPT ); Sun, 26 Apr 2015 06:21:29 -0400 Date: Sun, 26 Apr 2015 12:21:23 +0200 From: Greg KH To: hujianyang Cc: stable@vger.kernel.org, Li Zefan , ben@decadent.org.uk, viro@zeniv.linux.org.uk Subject: Re: [PATCH 2/2] deal with deadlock in d_walk() Message-ID: <20150426102123.GA31776@kroah.com> References: <54D31B6D.3070709@huawei.com> <54D31CD5.1070102@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54D31CD5.1070102@huawei.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Feb 05, 2015 at 03:33:41PM +0800, hujianyang wrote: > From: Al Viro > > commit ca5358ef75fc69fee5322a38a340f5739d997c10 upstream. > > ... by not hitting rename_retry for reasons other than rename having > happened. In other words, do _not_ restart when finding that > between unlocking the child and locking the parent the former got > into __dentry_kill(). Skip the killed siblings instead... > > Signed-off-by: Al Viro > Cc: Ben Hutchings > [hujianyang: Backported to 3.10 refer to the work of Ben Hutchings in 3.2: > - As we only have try_to_ascend() and not d_walk(), apply this > change to all callers of try_to_ascend() > - Adjust context to make __dentry_kill() apply to d_kill()] > Signed-off-by: hujianyang > --- > fs/dcache.c | 102 ++++++++++++++++++++++++++++++++++++----------------------- > 1 files changed, 62 insertions(+), 40 deletions(-) Can you provide a version for 3.14-stable as well? thanks, greg k-h