[stable request] mlx4 & dev_kfree_skb [was: [PATCHES] Networking]

[stable request] mlx4 & dev_kfree_skb [was: [PATCHES] Networking]

[Jiri Slaby]

On 04/21/2015, 08:30 PM, David Miller wrote:
> Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
> 3.19, and 4.0 -stable, respectively.

Hi,

similar to other "Call dev_kfree_skby_any instead of dev_kfree_skb.", I
believe, that mlx4 (only) in 3.14 should receive the fix too:

commit e81f44b66b456a7dcfbdeffeb355458cd6a58973
Author: Eric W. Biederman <ebiederm@xmission.com>
Date:   Tue Mar 11 14:19:14 2014 -0700

    mlx4: Call dev_kfree_skby_any instead of dev_kfree_skb.


In 3.12, it calls dev_kfree_skb_any yet.
In 3.14, it was changed to dev_kfree_skb.
In 3.18, it was changed to dev_consume_skb_any.

So please consider the commit above for the next 3.14 update.

thanks,
-- 
js
suse labs

Re: [stable request] mlx4 & dev_kfree_skb

[David Miller]

From: Jiri Slaby <jslaby@suse.cz>
Date: Mon, 27 Apr 2015 11:10:51 +0200

> On 04/21/2015, 08:30 PM, David Miller wrote:
>> Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
>> 3.19, and 4.0 -stable, respectively.
> 
> Hi,
> 
> similar to other "Call dev_kfree_skby_any instead of dev_kfree_skb.", I
> believe, that mlx4 (only) in 3.14 should receive the fix too:

No, enough is enough.  I didn't even want to submit the first series you
asked for.

Re: [PATCHES] Networking

[Jiri Slaby]

On 04/21/2015, 08:30 PM, David Miller wrote:
> 
> Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
> 3.19, and 4.0 -stable, respectively.

FWIW if anyone else wants to put there the missing "commit upstream"
tags for some patches too, I dug them out:
    gianfar: Carefully free skbs in functions called by netpoll.
    commit c9974ad4aeb36003860100221a594f3c0ccc3f78 upstream.

    benet: Call dev_kfree_skby_any instead of kfree_skb.
    commit d8ec2c02caa3515f35d6c33eedf529394c419298 upstream.

    ixgb: Call dev_kfree_skby_any instead of dev_kfree_skb.
    commit f7e79913a1d6a6139211ead3b03579b317d25a1f upstream.

    tg3: Call dev_kfree_skby_any instead of dev_kfree_skb.
    commit 497a27b9e1bcf6dbaea7a466cfcd866927e1b431 upstream.

    bnx2: Call dev_kfree_skby_any instead of dev_kfree_skb.
    commit f458b2ee93ee3606c83f76213fbe49e026bac754 upstream.

    bonding: Call dev_kfree_skby_any instead of kfree_skb.
    commit 2bb77ab42a6a40162a367b80394b96bb756ad5f1 upstream.

    r8169: Call dev_kfree_skby_any instead of dev_kfree_skb.
    commit 989c9ba104d9ce53c1ca918262f3fdfb33aca12a upstream.

    8139too: Call dev_kfree_skby_any instead of dev_kfree_skb.
    commit a2ccd2e4bd70122523a7bf21cec4dd6e34427089 upstream.

    8139cp: Call dev_kfree_skby_any instead of kfree_skb.
    commit 508f81d517ed1f3f0197df63ea7ab5cd91b6f3b3 upstream.


thanks,
-- 
js
suse labs

Re: [PATCHES] Networking

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Mon, 2015-04-27 at 11:23 +0200, Jiri Slaby wrote:
> On 04/21/2015, 08:30 PM, David Miller wrote:
> > 
> > Please queue up the following networking bug fixes for 3.12, 3.14, 3.18,
> > 3.19, and 4.0 -stable, respectively.
> 
> FWIW if anyone else wants to put there the missing "commit upstream"
> tags for some patches too, I dug them out:
[...]

Thanks for these.

Ben.

-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]