From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-lb0-f177.google.com ([209.85.217.177]:34142 "EHLO
	mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S966146AbbD2HoS (ORCPT
	<rfc822;stable@vger.kernel.org>); Wed, 29 Apr 2015 03:44:18 -0400
Date: Wed, 29 Apr 2015 09:44:20 +0200
From: Johan Hovold <johan@kernel.org>
To: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Milo Kim <milo.kim@ti.com>,
	patches@opensource.wolfsonmicro.com,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe
Message-ID: <20150429074420.GA24139@localhost>
References: <20150325110231.GC10412@localhost>
 <1427281625-31241-1-git-send-email-johan@kernel.org>
 <20150326083209.GE5951@x1>
 <20150414130406.GA26326@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150414130406.GA26326@localhost>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Apr 14, 2015 at 03:04:06PM +0200, Johan Hovold wrote:
> Hi Mark and Lee,
> 
> On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote:
> > On Wed, 25 Mar 2015, Johan Hovold wrote:
> > 
> > > Fix broken probe of da9052 regulators, which since commit b3f6c73db732
> > > ("mfd: da9052-core: Fix platform-device id collision") use a
> > > non-deterministic platform-device id to retrieve static regulator
> > > information. Fortunately, adequate error handling was in place so probe
> > > would simply fail with an error message.
> > > 
> > > Update the mfd-cell ids to be zero-based and use those to identify the
> > > cells when probing the regulator devices.
> > > 
> > > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision")
> > > Cc: stable <stable@vger.kernel.org>	# v3.19
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > >  drivers/mfd/da9052-core.c            | 8 ++++----
> > >  drivers/regulator/da9052-regulator.c | 5 +++--
> > 
> > Need an Ack from Mark, but looks good to me.
> > 
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> 
> Mark, did you have a chance to look at this one?
> 
> It fixes a regression due to an mfd commit, but not sure who of you that
> wants to take it.

It's now been over a month and this still hasn't been applied even
though it fixes a regression.

Lee, perhaps you should take it through MFD as it was an MFD commit that
broke it?

Johan