From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com ([74.125.82.54]:33093 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031507AbbD2Il5 (ORCPT ); Wed, 29 Apr 2015 04:41:57 -0400 Received: by wgin8 with SMTP id n8so20286855wgi.0 for ; Wed, 29 Apr 2015 01:41:56 -0700 (PDT) Date: Wed, 29 Apr 2015 09:41:52 +0100 From: Lee Jones To: Johan Hovold Cc: Mark Brown , Support Opensource , Samuel Ortiz , Liam Girdwood , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Milo Kim , patches@opensource.wolfsonmicro.com, Fabio Estevam , Marek Szyprowski , stable Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe Message-ID: <20150429084152.GP9169@x1> References: <20150325110231.GC10412@localhost> <1427281625-31241-1-git-send-email-johan@kernel.org> <20150326083209.GE5951@x1> <20150414130406.GA26326@localhost> <20150429074420.GA24139@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150429074420.GA24139@localhost> Sender: stable-owner@vger.kernel.org List-ID: On Wed, 29 Apr 2015, Johan Hovold wrote: > On Tue, Apr 14, 2015 at 03:04:06PM +0200, Johan Hovold wrote: > > Hi Mark and Lee, > > > > On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote: > > > On Wed, 25 Mar 2015, Johan Hovold wrote: > > > > > > > Fix broken probe of da9052 regulators, which since commit b3f6c73db732 > > > > ("mfd: da9052-core: Fix platform-device id collision") use a > > > > non-deterministic platform-device id to retrieve static regulator > > > > information. Fortunately, adequate error handling was in place so probe > > > > would simply fail with an error message. > > > > > > > > Update the mfd-cell ids to be zero-based and use those to identify the > > > > cells when probing the regulator devices. > > > > > > > > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision") > > > > Cc: stable # v3.19 > > > > Signed-off-by: Johan Hovold > > > > --- > > > > drivers/mfd/da9052-core.c | 8 ++++---- > > > > drivers/regulator/da9052-regulator.c | 5 +++-- > > > > > > Need an Ack from Mark, but looks good to me. > > > > > > Acked-by: Lee Jones > > > > Mark, did you have a chance to look at this one? > > > > It fixes a regression due to an mfd commit, but not sure who of you that > > wants to take it. > > It's now been over a month and this still hasn't been applied even > though it fixes a regression. > > Lee, perhaps you should take it through MFD as it was an MFD commit that > broke it? I'm in the same situation -- can't do anything without an Ack from Mark. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog