From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net ([208.91.199.152]:45257 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbbEDSvx (ORCPT ); Mon, 4 May 2015 14:51:53 -0400 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.85) (envelope-from ) id 1YpLT6-002uGG-1u for stable@vger.kernel.org; Mon, 04 May 2015 18:51:52 +0000 Date: Mon, 4 May 2015 11:51:33 -0700 From: Guenter Roeck To: Heiko Carstens Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah.kh@samsung.com, stable , Martin Schwidefsky , Rabin Vincent , Steven Rostedt Subject: Re: [PATCH 3.10 00/65] 3.10.77-stable review Message-ID: <20150504185133.GA31982@roeck-us.net> References: <20150502190114.555225285@linuxfoundation.org> <55467BDC.6000407@roeck-us.net> <5546F82B.5040009@roeck-us.net> <20150504080914.GA5159@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504080914.GA5159@osiris> Sender: stable-owner@vger.kernel.org List-ID: On Mon, May 04, 2015 at 10:09:14AM +0200, Heiko Carstens wrote: > On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote: > > On 05/03/2015 12:49 PM, Guenter Roeck wrote: > > >On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote: > > >>This is the start of the stable review cycle for the 3.10.77 release. > > >>There are 65 patches in this series, all will be posted as a response > > >>to this one. If anyone has any issues with these being applied, please > > >>let me know. > > >> > > >>Responses should be made by Mon May 4 19:00:04 UTC 2015. > > >>Anything received after that time might be too late. > > >> > > Also, for s390, similar to the error seen in 3.14: > > > > arch/s390/kernel/suspend.c: In function 'pfn_is_nosave': > > arch/s390/kernel/suspend.c:141:30: error: '_eshared' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:141:30: note: each undeclared identifier is reported only once for each function it appears in > > arch/s390/kernel/suspend.c:142:28: error: '_stext' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:151:10: error: 'ipl_info' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:151:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function) > > > > Presumably for the same reason ('s390/hibernate: fix save and restore of kernel text section'). > > Oh, crap.. for 3.10 two includes are missing within arch/s390/kernel/suspend.c: > and > > The corresponding commits are: > ipl.h: > 77e844b9644026c11c5883144540155de39af767 > "s390/hibernate: add early resume function" > (applies cleanly to 3.10, and was merged with 3.12) > > sections.h > 7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0 > "nosave: consolidate __nosave_{begin,end} in " > > This one is ugly, since it touches a lot of architectures and depends on a > lot of other unrelated patches. I'd say it's easier to add an extra patch that > simply adds the missing include, hm? (or add the include to the patch) > The same as true for the build failure on 3.14, unfortunately. > > Does that make sense? > Adding the missing include file(s) to the patch seems to be an easier solution and would be a valid backport, at least in my opinion. I did a quick test. The s390:defconfig build passes after adding commit 77e844b9644026c11c5883144540155de39af767 and adding "#include " to the hibernate patch. s390:allmodconfig still fails to build for other reasons (because devm_request_threaded_irq and irq_create_mapping are not supported for s390 in 3.10), but that is a different issue. Guenter