Re: [PATCH 3.10 48/65] gpio: mvebu: Fix mask/unmask managment per irq chip type

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, May 03, 2015 at 10:20:19AM +0200, Christoph Biedl wrote:
> Greg Kroah-Hartman wrote...
> 
> > From: Gregory CLEMENT <gregory.clement@free-electrons.com>
> > 
> > commit 61819549f572edd7fce53f228c0d8420cdc85f71 upstream.
> > 
> > Level IRQ handlers and edge IRQ handler are managed by tow different
> > sets of registers. But currently the driver uses the same mask for the
> > both registers. It lead to issues with the following scenario:
> (...)
> 
> This results in a build breakage:
> 
> (...)
> |   CC      drivers/gpio/gpio-mvebu.o
> | drivers/gpio/gpio-mvebu.c: In function 'mvebu_gpio_edge_irq_mask':
> | drivers/gpio/gpio-mvebu.c:311:4: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c:313:2: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c: In function 'mvebu_gpio_edge_irq_unmask':
> | drivers/gpio/gpio-mvebu.c:326:4: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c:327:2: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c: In function 'mvebu_gpio_level_irq_mask':
> | drivers/gpio/gpio-mvebu.c:340:4: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c:341:2: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c: In function 'mvebu_gpio_level_irq_unmask':
> | drivers/gpio/gpio-mvebu.c:354:4: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> | drivers/gpio/gpio-mvebu.c:355:2: error: 'struct irq_chip_type' has no member named 'mask_cache_priv'
> 
> Perhaps picking
> 
> | commit 899f0e66fff36ebb6dd6a83af9aa631f6cb7e0dc
> | Author: Gerlando Falauto <gerlando.falauto@keymile.com>
> | Date:   Mon May 6 14:30:19 2013 +0000
> | 
> |     genirq: Generic chip: Add support for per chip type mask cache
> 
> will fix this but I couldn't check yet: My box is still busy test-building the
> 3.14 series.

I'm going to drop the original patch here, if someone wants me to apply
it to 3.10, please send a working backported patch (or series of
patches.)

thanks,

greg k-h