From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wtarreau.pck.nerim.net ([62.212.114.60]:36182 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934676AbbEOIPm (ORCPT ); Fri, 15 May 2015 04:15:42 -0400 Message-Id: <20150515080530.891249915@1wt.eu> Date: Fri, 15 May 2015 10:05:44 +0200 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Robert Baldyga , Greg Kroah-Hartman , Willy Tarreau Subject: [ 14/48] serial: samsung: wait for transfer completion before clock disable MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 In-Reply-To: <9c2783dfae10ef2d1e9b08bcc1e562c5@local> Sender: stable-owner@vger.kernel.org List-ID: 2.6.32-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Robert Baldyga This patch adds waiting until transmit buffer and shifter will be empty before clock disabling. Without this fix it's possible to have clock disabled while data was not transmited yet, which causes unproper state of TX line and problems in following data transfers. Cc: stable@vger.kernel.org Signed-off-by: Robert Baldyga Signed-off-by: Greg Kroah-Hartman (cherry picked from commit 1ff383a4c3eda8893ec61b02831826e1b1f46b41) Signed-off-by: Willy Tarreau --- drivers/serial/samsung.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c index 1523e8d..05801c0 100644 --- a/drivers/serial/samsung.c +++ b/drivers/serial/samsung.c @@ -443,11 +443,15 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, unsigned int old) { struct s3c24xx_uart_port *ourport = to_ourport(port); + int timeout = 10000; ourport->pm_level = level; switch (level) { case 3: + while (--timeout && !s3c24xx_serial_txempty_nofifo(port)) + udelay(100); + if (!IS_ERR(ourport->baudclk) && ourport->baudclk != NULL) clk_disable(ourport->baudclk); -- 1.7.12.2.21.g234cd45.dirty