Re: [PATCH 0/4] Fix v3.14.41 ARCH=i386 ACPI build warnings

[Luis Henriques <luis.henriques@canonical.com>]

On Tue, May 12, 2015 at 05:28:18PM -0400, George G. Davis wrote:
> From: "George G. Davis" <george_davis@mentor.com>
> 
> Hello,
> 
> The following changes introduced in the recent v3.14.41 update have introduced
> build warnings for the ARCH=i386 case:
> 
> a26f0f3 ACPICA: Utilities: split IO address types from data type models.
> 8c56b5e ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()
> 

Thanks, I'm queuing all of these patches for the 3.16 kernel as well.

Cheers,
--
Luís

> 
> As of v3.14.41, the following new build warnings exist for the `make ARCH=i386
> i386_defconfig bzImage` case:
> 
>   CC      drivers/acpi/osl.o
> drivers/acpi/osl.c: In function ‘acpi_os_get_root_pointer’:
> drivers/acpi/osl.c:264:3: warning: passing argument 1 of ‘acpi_find_root_pointer’ from incompatible pointer type [enabled by default]
>    acpi_find_root_pointer(&pa);
>    ^
> In file included from include/acpi/acpi.h:64:0,
>                  from include/linux/acpi.h:42,
>                  from drivers/acpi/osl.c:41:
> include/acpi/acpixf.h:178:123: note: expected ‘acpi_size *’ but argument is of type ‘acpi_physical_address *’
>  acpi_status __init acpi_find_root_pointer(acpi_size *rsdp_address);
>                                                                                                                            ^
>   CC      drivers/acpi/acpica/exregion.o
> drivers/acpi/acpica/exregion.c: In function ‘acpi_ex_system_memory_space_handler’:
> drivers/acpi/acpica/exregion.c:182:4: warning: format ‘%X’ expects argument of type ‘unsigned int’, but argument 5 has type ‘acpi_physical_address’ [-Wformat=]
>     ACPI_ERROR((AE_INFO,
>     ^
>   CC      drivers/acpi/acpica/hwvalid.o
> drivers/acpi/acpica/hwvalid.c: In function ‘acpi_hw_validate_io_request’:
> drivers/acpi/acpica/hwvalid.c:153:103: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    ACPI_ERROR((AE_INFO,
>                                                                                                        ^
>   CC      drivers/acpi/acpica/tbinstal.o
> drivers/acpi/acpica/tbinstal.c: In function ‘acpi_tb_table_override’:
> drivers/acpi/acpica/tbinstal.c:294:167: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     ACPI_EXCEPTION((AE_INFO, AE_NO_MEMORY,
>                                                                                                                                                                        ^
> drivers/acpi/acpica/tbinstal.c:311:117: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   ACPI_INFO((AE_INFO,
>                                                                                                                      ^
>   CC      drivers/acpi/acpica/tbprint.o
> drivers/acpi/acpica/tbprint.c: In function ‘acpi_tb_print_table_header’:
> drivers/acpi/acpica/tbprint.c:138:84: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    ACPI_INFO((AE_INFO, "%4.4s %p %06X",
>                                                                                     ^
> drivers/acpi/acpica/tbprint.c:150:78: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    ACPI_INFO((AE_INFO, "RSDP %p %06X (v%.2d %6.6s)",
>                                                                               ^
> drivers/acpi/acpica/tbprint.c:164:125: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    ACPI_INFO((AE_INFO,
>                                                                                                                              ^
>   CC      drivers/acpi/acpica/tbutils.o
> drivers/acpi/acpica/tbutils.c: In function ‘acpi_tb_install_table’:
> drivers/acpi/acpica/tbutils.c:229:105: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    ACPI_ERROR((AE_INFO,
>                                                                                                          ^
>   CC      drivers/acpi/acpica/tbxfload.o
> drivers/acpi/acpica/tbxfload.c: In function ‘acpi_tb_load_namespace’:
> drivers/acpi/acpica/tbxfload.c:187:126: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     ACPI_INFO((AE_INFO, "Ignoring %4.4s at %p",
>                                                                                                                               ^
>   CC      drivers/acpi/acpica/utaddress.o
> drivers/acpi/acpica/utaddress.c: In function ‘acpi_ut_check_address_range’:
> drivers/acpi/acpica/utaddress.c:247:149: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      ACPI_WARNING((AE_INFO,
>                                                                                                                                                      ^
> drivers/acpi/acpica/utaddress.c:247:180: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      ACPI_WARNING((AE_INFO,
>                                                                                                                                                                                     ^
> drivers/acpi/acpica/utaddress.c:247:215: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      ACPI_WARNING((AE_INFO,
>                                                                                                                                                                                                                        ^
> drivers/acpi/acpica/utaddress.c:247:265: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      ACPI_WARNING((AE_INFO,
>                                                                                                                                                                                                                                                                          ^
> 
> The following upstream commits have been backported to v3.14.41 in order to
> resolve the above build warnings:
> 
> Lv Zheng (4):
>   ACPICA: Tables: Change acpi_find_root_pointer() to use
>     acpi_physical_address.
>   ACPICA: Utilities: Cleanup to enforce
>     ACPI_PHYSADDR_TO_PTR()/ACPI_PTR_TO_PHYSADDR().
>   ACPICA: Utilities: Cleanup to convert physical address printing
>     formats.
>   ACPICA: Utilities: Cleanup to remove useless ACPI_PRINTF/FORMAT_xxx
>     helpers.
> 
>  drivers/acpi/acpica/acmacros.h  | 10 +++-------
>  drivers/acpi/acpica/dsopcode.c  |  7 +++----
>  drivers/acpi/acpica/evregion.c  |  2 +-
>  drivers/acpi/acpica/exdump.c    |  4 ++--
>  drivers/acpi/acpica/exfldio.c   | 10 ++++------
>  drivers/acpi/acpica/exregion.c  |  8 +++-----
>  drivers/acpi/acpica/hwvalid.c   | 16 ++++++++--------
>  drivers/acpi/acpica/nsdump.c    | 12 ++++++------
>  drivers/acpi/acpica/tbinstal.c  |  5 ++---
>  drivers/acpi/acpica/tbprint.c   | 17 +++++++----------
>  drivers/acpi/acpica/tbutils.c   |  4 ++--
>  drivers/acpi/acpica/tbxfload.c  |  7 +++----
>  drivers/acpi/acpica/tbxfroot.c  |  7 ++++---
>  drivers/acpi/acpica/utaddress.c | 34 +++++++++++++++-------------------
>  include/acpi/acpixf.h           |  2 +-
>  15 files changed, 64 insertions(+), 81 deletions(-)
> 
> Please review and apply.
> 
> Thanks in advance!
> 
> --
> Regards,
> George
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html