From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e2big.org ([198.61.226.133]:43167 "EHLO e2big.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbbE1Sn5 (ORCPT ); Thu, 28 May 2015 14:43:57 -0400 Date: Thu, 28 May 2015 20:19:48 +0200 From: ulrik.debie-os@e2big.org To: Hans de Goede Cc: Dmitry Torokhov , Peter Hutterer , Benjamin Tissoires , linux-input@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] elantech: Fix detection of touchpads where the revision matches a known rate Message-ID: <20150528181947.GA2572@lantern> References: <1432804171-3878-1-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432804171-3878-1-git-send-email-hdegoede@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: Hi Hans, On Thu, May 28, 2015 at 11:09:31AM +0200, Hans de Goede wrote: > > Make the check to skip the rate check more lax, so that it applies > to all hw_version 4 models. > > This fixes the touchpad not being detected properly on Asus PU551LA > laptops. > > Cc: stable@vger.kernel.org > Reported-and-tested-by: David Zafra G�mez > Signed-off-by: Hans de Goede > --- > drivers/input/mouse/elantech.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 79363b6..e605303 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -1379,7 +1379,8 @@ static bool elantech_is_signature_valid(const unsigned char *param) > * Some models have a revision higher then 20. Meaning param[2] may > * be 10 or 20, skip the rates check for these. > */ Would it not be best to also update the comment here ? That it will skip rate check in that case for all hw version 4+ when revision is higher than .. > - if (param[0] == 0x46 && (param[1] & 0xef) == 0x0f && param[2] < 40) > + if ((param[0] & 0x0f) >= 0x06 && (param[1] & 0xaf) == 0x0f && > + param[2] < 40) > return true; > > for (i = 0; i < ARRAY_SIZE(rates); i++) > -- > 2.4.1 > Kind regards, Ulrik