From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:33151 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbbFCJoS (ORCPT ); Wed, 3 Jun 2015 05:44:18 -0400 Date: Wed, 3 Jun 2015 10:44:15 +0100 From: Luis Henriques To: gregkh@linuxfoundation.org Cc: anarsoul@gmail.com, broonie@kernel.org, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "ASoC: uda1380: Avoid accessing i2c bus when codec is disabled" has been added to the 3.10-stable tree Message-ID: <20150603094415.GC1737@ares> References: <143329513250101@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <143329513250101@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jun 03, 2015 at 10:32:12AM +0900, Greg Kroah-Hartman wrote: > > This is a note to let you know that I've just added the patch titled > > ASoC: uda1380: Avoid accessing i2c bus when codec is disabled > > to the 3.10-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > asoc-uda1380-avoid-accessing-i2c-bus-when-codec-is-disabled.patch > and it can be found in the queue-3.10 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. > I'm not sure this should be applied to 3.10 (or even 3.14) as the 'Fixes:' commits are not present on these kernels. Cheers, -- Lu�s > > From 810e4425c224af6be67dff68c8832af1b5a11f89 Mon Sep 17 00:00:00 2001 > From: Vasily Khoruzhick > Date: Sun, 3 May 2015 21:11:47 +0300 > Subject: ASoC: uda1380: Avoid accessing i2c bus when codec is disabled > > From: Vasily Khoruzhick > > commit 810e4425c224af6be67dff68c8832af1b5a11f89 upstream. > > set_dai_fmt_both() callback is called from snd_soc_runtime_set_dai_fmt() > which is called from snd_soc_register_card(), but at this time codec > is not powered on yet. Replace direct i2c write with regcache write. > > Fixes: 5f0acedddf533c (ASoC: rx1950_uda1380: Use static DAI format setup) > Fixes: 5cc10b9b77c234 (ASoC: h1940_uda1380: Use static DAI format setup) > Signed-off-by: Vasily Khoruzhick > Signed-off-by: Mark Brown > Signed-off-by: Greg Kroah-Hartman > > --- > sound/soc/codecs/uda1380.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/sound/soc/codecs/uda1380.c > +++ b/sound/soc/codecs/uda1380.c > @@ -435,7 +435,7 @@ static int uda1380_set_dai_fmt_both(stru > if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) != SND_SOC_DAIFMT_CBS_CFS) > return -EINVAL; > > - uda1380_write(codec, UDA1380_IFACE, iface); > + uda1380_write_reg_cache(codec, UDA1380_IFACE, iface); > > return 0; > } > > > Patches currently in stable-queue which might be from anarsoul@gmail.com are > > queue-3.10/asoc-uda1380-avoid-accessing-i2c-bus-when-codec-is-disabled.patch > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html