Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kevin Hilman <khilman@kernel.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Ben Hutchings <ben@decadent.org.uk>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Nicolas Pitre <nico@linaro.org>,
	Dave Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH stable/4.0.y] ARM: 8325/1: exynos: move resume code to .text section
Date: Mon, 15 Jun 2015 23:59:41 +0100	[thread overview]
Message-ID: <20150615225941.GQ7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <7hwpz439c1.fsf@deeprootsystems.com>

On Mon, Jun 15, 2015 at 03:17:34PM -0700, Kevin Hilman wrote:
> Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
> 
> > On 15 June 2015 at 13:08, Russell King - ARM Linux
> [...]
> 
> >> I think the question is - what's caused stable-4.0 to start spitting
> >> these errors?  Presumably, 4.0 didn't, and stable-4.0 has regressed?
> >> Maybe, rather than trying to fix this new regression, the original
> >> cause should be reverted?
> >>
> >
> > Not sure whether it's a regression. I think this code does not usually
> > get built in Thumb2 mode in the first place.
> 
> It's not a regression in stable-4.0, v4.0 has the same build failure.  
> 
> I think we've only caught this now since I added multi_v7 +
> CONFIG_THUMB2_KERNEL=y builds to kernelci.org for mainline and the
> stable trees.

Okay, so it's not a user reported regression, but comes from a build
system.  So I continue to wonder what the value is of trying to fix
it in stable kernels, vs the risk of de-stabilising them, especially
when the fix we have in mainline can't be applied.

I'd suggest waiting until we have proper users reporting a failure
over this.  (Who's a proper user?)

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-06-15 22:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  2:42 [PATCH stable/4.0.y] ARM: 8325/1: exynos: move resume code to .text section Kevin Hilman
2015-06-14 23:13 ` Ben Hutchings
2015-06-15  7:04   ` Ard Biesheuvel
2015-06-15 11:08     ` Russell King - ARM Linux
2015-06-15 14:20       ` Ard Biesheuvel
2015-06-15 22:17         ` Kevin Hilman
2015-06-15 22:59           ` Russell King - ARM Linux [this message]
2015-06-16 10:09             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615225941.GQ7557@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Dave.Martin@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ben@decadent.org.uk \
    --cc=khilman@kernel.org \
    --cc=nico@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox