From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.us.es ([193.147.175.20]:47878 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932864AbbFPKSd (ORCPT ); Tue, 16 Jun 2015 06:18:33 -0400 Date: Tue, 16 Jun 2015 12:23:44 +0200 From: Pablo Neira Ayuso To: lizf@kernel.org Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Zefan Li Subject: Re: [PATCH 3.4 051/172] netfilter: xt_socket: fix a stack corruption bug Message-ID: <20150616102344.GC3591@salvia> References: <1434443587-4599-1-git-send-email-lizf@kernel.org> <1434443826-4929-51-git-send-email-lizf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434443826-4929-51-git-send-email-lizf@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jun 16, 2015 at 04:35:05PM +0800, lizf@kernel.org wrote: > From: Eric Dumazet > > 3.4.108-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > > commit 78296c97ca1fd3b104f12e1f1fbc06c46635990b upstream. > > As soon as extract_icmp6_fields() returns, its local storage (automatic > variables) is deallocated and can be overwritten. > > Lets add an additional parameter to make sure storage is valid long > enough. > > While we are at it, adds some const qualifiers. > > Signed-off-by: Eric Dumazet > Fixes: b64c9256a9b76 ("tproxy: added IPv6 support to the socket match") > Signed-off-by: Pablo Neira Ayuso > [lizf: Backported to 3.4: adjust context] > Signed-off-by: Zefan Li Thanks for backporting this for 3.4. Acked-by: Pablo Neira Ayuso