Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 7a6cb0abe1aa63334f3ded6d2b6c8eca80e72302 Mon Sep 17 00:00:00 2001
From: Matthijs van Duin <matthijsvanduin@gmail.com>
Date: Mon, 1 Jun 2015 21:33:28 +0200
Subject: ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

From: Matthijs van Duin <matthijsvanduin@gmail.com>

commit 7a6cb0abe1aa63334f3ded6d2b6c8eca80e72302 upstream.

Avoid entering "RTC-only mode" at poweroff. It is unsupported by most
versions of BeagleBone, and risks hardware damage.

The damaging configuration is having system-power-controller
without ti,pmic-shutdown-controller.

Reported-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Tested-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Johan Hovold <johan@kernel.org>
[Matthijs van Duin: added explanatory comments]
Signed-off-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Fixes: http://bugs.elinux.org/issues/143
[tony@atomide.com: updated comments with the hardware breaking info]
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/arm/boot/dts/am335x-bone-common.dtsi |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -226,6 +226,25 @@
 /include/ "tps65217.dtsi"
 
 &tps {
+	/*
+	 * Configure pmic to enter OFF-state instead of SLEEP-state ("RTC-only
+	 * mode") at poweroff.  Most BeagleBone versions do not support RTC-only
+	 * mode and risk hardware damage if this mode is entered.
+	 *
+	 * For details, see linux-omap mailing list May 2015 thread
+	 *	[PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller
+	 * In particular, messages:
+	 *	http://www.spinics.net/lists/linux-omap/msg118585.html
+	 *	http://www.spinics.net/lists/linux-omap/msg118615.html
+	 *
+	 * You can override this later with
+	 *	&tps {  /delete-property/ ti,pmic-shutdown-controller;  }
+	 * if you want to use RTC-only mode and made sure you are not affected
+	 * by the hardware problems. (Tip: double-check by performing a current
+	 * measurement after shutdown: it should be less than 1 mA.)
+	 */
+	ti,pmic-shutdown-controller;
+
 	regulators {
 		dcdc1_reg: regulator@0 {
 			regulator-always-on;


Patches currently in stable-queue which might be from matthijsvanduin@gmail.com are

queue-3.14/arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in

Re: Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

[Johan Hovold]

On Fri, Jun 19, 2015 at 12:43:27PM -0700, Greg Kroah-Hartman wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage
> 
> to the 3.14-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
> and it can be found in the queue-3.14 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

This one can be dropped from 3.14-stable as it is only needed in 3.19
and later kernels that have commit 672e2b147413 ("ARM: dts:
am335x-boneblack: enable power off and rtc wake up").

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe stable" in

Re: Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

[Greg KH]

On Mon, Jun 22, 2015 at 10:20:24AM +0200, Johan Hovold wrote:
> On Fri, Jun 19, 2015 at 12:43:27PM -0700, Greg Kroah-Hartman wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage
> > 
> > to the 3.14-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
> > and it can be found in the queue-3.14 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> 
> This one can be dropped from 3.14-stable as it is only needed in 3.19
> and later kernels that have commit 672e2b147413 ("ARM: dts:
> am335x-boneblack: enable power off and rtc wake up").

Thanks, now dropped.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in