From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53566 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbbF2WtX (ORCPT ); Mon, 29 Jun 2015 18:49:23 -0400 Date: Mon, 29 Jun 2015 15:49:22 -0700 From: Greg KH To: Preeti U Murthy Cc: stable@vger.kernel.org, mingo@kernel.org, linux@roeck-us.net Subject: Re: [PATCH3/5] tick: Simplify tick-internal.h Message-ID: <20150629224922.GA19806@kroah.com> References: <20150513114717.27807.18777.stgit@preeti.in.ibm.com> <20150513115022.27807.79082.stgit@preeti.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150513115022.27807.79082.stgit@preeti.in.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, May 13, 2015 at 05:20:23PM +0530, Preeti U Murthy wrote: > From: Thomas Gleixner > > commit b7475eb599ddb2e8cab2dc86ff38a9507463ad6b upstream > > tick-internal.h is pretty confusing as a lot of the stub inlines > are there several times. > > Distangle the maze and make clear functional sections. > > Signed-off-by: Thomas Gleixner > [ rjw: Subject ] > Signed-off-by: Rafael J. Wysocki > Cc: Peter Zijlstra > Link: http://lkml.kernel.org/r/16068264.vcNp79HLaT@vostro.rjw.lan > Signed-off-by: Ingo Molnar > Signed-off-by: Preeti U Murthy You don't mention that you changed this function from what it is upstream, which isn't ok to do without a good reason. I'm really not liking this series, it's very intrusive for almost no gain. In other words, you have a very specific platform, with limited users, and a limited use case, yet are asking for core timer functions to be made for a kernel that I'm going to stop maintaining after the next release. In other words, these patches are going to only have a lifespan of 1 more week, max. By then, all your users should be on 4.1, so 4.0 doesn't matter anymore. So I'm just going to drop this whole series, sorry. If you have a distro that "has to have these", then please work with them, otherwise, just use 4.1, as all is good, and most importantly, properly tested, there. thanks, greg k-h