From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([78.46.96.112]:58240 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbbGYJDp (ORCPT ); Sat, 25 Jul 2015 05:03:45 -0400 Date: Sat, 25 Jul 2015 11:03:40 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Peter Zijlstra , Steven Rostedt , "security@kernel.org" , X86 ML , Sasha Levin , linux-kernel@vger.kernel.org, Konrad Rzeszutek Wilk , Boris Ostrovsky , Andrew Cooper , Jan Beulich , xen-devel , stable@vger.kernel.org Subject: Re: [PATCH v4 1/3] x86/ldt: Make modify_ldt synchronous Message-ID: <20150725090340.GD3427@nazgul.tnic> References: <12ddcec938d76238975dff9de7d66cfc6e574aa7.1437802102.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <12ddcec938d76238975dff9de7d66cfc6e574aa7.1437802102.git.luto@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 24, 2015 at 10:36:44PM -0700, Andy Lutomirski wrote: > modify_ldt has questionable locking and does not synchronize > threads. Improve it: redesign the locking and synchronize all > threads' LDTs using an IPI on all modifications. > > This will dramatically slow down modify_ldt in multithreaded > programs, but there shouldn't be any multithreaded programs that > care about modify_ldt's performance in the first place. > > Cc: stable@vger.kernel.org > Signed-off-by: Andy Lutomirski Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --