From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:35945 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbbG2Gxh (ORCPT ); Wed, 29 Jul 2015 02:53:37 -0400 Date: Wed, 29 Jul 2015 12:23:31 +0530 From: Sudip Mukherjee To: Miguel Ojeda Sandonis , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/4] auxdisplay: ks0108: fix refcount Message-ID: <20150729065330.GB4169@sudip-pc> References: <1437393444-32035-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437393444-32035-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jul 20, 2015 at 05:27:21PM +0530, Sudip Mukherjee wrote: > parport_find_base() will implicitly do parport_get_port() which > increases the refcount. Then parport_register_device() will again > increment the refcount. But while unloading the module we are only > doing parport_unregister_device() decrementing the refcount only once. > We add an parport_put_port() to neutralize the effect of > parport_get_port(). > > Cc: # 2.6.32+ > Signed-off-by: Sudip Mukherjee > --- Hi Miguel, A gentle ping. regards sudip