From: Jakub Kicinski <kubakici@wp.pl>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org
Subject: Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
Date: Fri, 31 Jul 2015 12:53:31 +0200 [thread overview]
Message-ID: <20150731125331.57c5e4cb@north> (raw)
In-Reply-To: <20150731010739.GB31169@kroah.com>
On Thu, 30 Jul 2015 18:07:39 -0700, Greg KH wrote:
> On Wed, Jun 03, 2015 at 06:54:38AM +0200, Jakub Kicinski wrote:
> > On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote:
> > > On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> > > > Please include following patch from Linus' tree in the 3.18 branch.
> > > > Without it SDHC is unusable on Freescale P2020. Thanks!
> > > >
> > > >
> > > > commit 556b5f33513f16450e8bb803c82a24377b94a34e
> > >
> > > I don't see this commit anywhere in Linus's tree. Where did you find
> > > it?
> >
> > Argh, stupidly I sent you the commit id from after I applied this to
> > 3.18... In Linus's tree it's 304f0a98d168, sorry.
> >
> >
> > commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
> > Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > Date: Tue Dec 9 09:40:38 2014 +0100
> >
> > mmc: sdhci: Fix FSL ESDHC reset handling quirk
> >
> > The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> > esdhc code") states that Freescale esdhc is the only controller which needs
> > the interrupt registers restored after a reset. So it moves
> > SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> > esdhc-imx driver only. Unfortunately the same controller is used in
> > other boards which use the of-esdhc driver instead (like powerpc P2020).
> >
> > Restore interrupts after reset in the sdhci-of-esdhc driver also.
> >
> > Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
>
> I don't remember tree what you wanted this applied to, so I tried
> 3.14-stable, and that didn't work. Can you be more specific?
OK, let me try again. I would like the following commit to be applied
to 3.18:
commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Date: Tue Dec 9 09:40:38 2014 +0100
mmc: sdhci: Fix FSL ESDHC reset handling quirk
The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
esdhc code") states that Freescale esdhc is the only controller which needs
the interrupt registers restored after a reset. So it moves
SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
esdhc-imx driver only. Unfortunately the same controller is used in
other boards which use the of-esdhc driver instead (like powerpc P2020).
Restore interrupts after reset in the sdhci-of-esdhc driver also.
Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Thanks!
next prev parent reply other threads:[~2015-07-31 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 14:37 mmc: sdhci: Fix FSL ESDHC reset handling quirk Jakub Kicinski
2015-06-03 0:46 ` Greg KH
2015-06-03 4:54 ` Jakub Kicinski
2015-07-31 1:07 ` Greg KH
2015-07-31 10:53 ` Jakub Kicinski [this message]
2015-07-31 16:37 ` Greg KH
2015-08-10 16:27 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731125331.57c5e4cb@north \
--to=kubakici@wp.pl \
--cc=greg@kroah.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).