From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38370 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbbGaQhu (ORCPT ); Fri, 31 Jul 2015 12:37:50 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 55CEF2034A for ; Fri, 31 Jul 2015 12:37:49 -0400 (EDT) Date: Fri, 31 Jul 2015 09:37:47 -0700 From: Greg KH To: Jakub Kicinski Cc: stable@vger.kernel.org Subject: Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk Message-ID: <20150731163747.GB6631@kroah.com> References: <20150602163709.71d1460c@north> <20150603004629.GA24127@kroah.com> <20150603065438.4fb78645@north> <20150731010739.GB31169@kroah.com> <20150731125331.57c5e4cb@north> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150731125331.57c5e4cb@north> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 31, 2015 at 12:53:31PM +0200, Jakub Kicinski wrote: > On Thu, 30 Jul 2015 18:07:39 -0700, Greg KH wrote: > > On Wed, Jun 03, 2015 at 06:54:38AM +0200, Jakub Kicinski wrote: > > > On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote: > > > > On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote: > > > > > Please include following patch from Linus' tree in the 3.18 branch. > > > > > Without it SDHC is unusable on Freescale P2020. Thanks! > > > > > > > > > > > > > > > commit 556b5f33513f16450e8bb803c82a24377b94a34e > > > > > > > > I don't see this commit anywhere in Linus's tree. Where did you find > > > > it? > > > > > > Argh, stupidly I sent you the commit id from after I applied this to > > > 3.18... In Linus's tree it's 304f0a98d168, sorry. > > > > > > > > > commit 304f0a98d168563b5f69c53a7544c36e6d221ac4 > > > Author: Alessio Igor Bogani > > > Date: Tue Dec 9 09:40:38 2014 +0100 > > > > > > mmc: sdhci: Fix FSL ESDHC reset handling quirk > > > > > > The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into > > > esdhc code") states that Freescale esdhc is the only controller which needs > > > the interrupt registers restored after a reset. So it moves > > > SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the > > > esdhc-imx driver only. Unfortunately the same controller is used in > > > other boards which use the of-esdhc driver instead (like powerpc P2020). > > > > > > Restore interrupts after reset in the sdhci-of-esdhc driver also. > > > > > > Signed-off-by: Alessio Igor Bogani > > > Signed-off-by: Ulf Hansson > > > > > > I don't remember tree what you wanted this applied to, so I tried > > 3.14-stable, and that didn't work. Can you be more specific? > > OK, let me try again. I would like the following commit to be applied > to 3.18: > > > commit 304f0a98d168563b5f69c53a7544c36e6d221ac4 > Author: Alessio Igor Bogani > Date: Tue Dec 9 09:40:38 2014 +0100 > > mmc: sdhci: Fix FSL ESDHC reset handling quirk > > The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into > esdhc code") states that Freescale esdhc is the only controller which needs > the interrupt registers restored after a reset. So it moves > SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the > esdhc-imx driver only. Unfortunately the same controller is used in > other boards which use the of-esdhc driver instead (like powerpc P2020). > > Restore interrupts after reset in the sdhci-of-esdhc driver also. > > Signed-off-by: Alessio Igor Bogani > Signed-off-by: Ulf Hansson > As I don't maintain 3.18, nothing I can do here, great! :)