From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46931 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbbGaQxi (ORCPT ); Fri, 31 Jul 2015 12:53:38 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F2DA320897 for ; Fri, 31 Jul 2015 12:53:37 -0400 (EDT) Date: Fri, 31 Jul 2015 09:53:36 -0700 From: Greg KH To: Mason Cc: stable@vger.kernel.org, LKML Subject: Re: Requesting inclusion of 12dd7ecf2323 in linux-3.14.y Message-ID: <20150731165336.GA7446@kroah.com> References: <55BBA61D.7060302@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55BBA61D.7060302@free.fr> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 31, 2015 at 06:45:17PM +0200, Mason wrote: > Hello Greg and al, > > Do you accept trivial patches for stable? Not really, take a look at Documentation/stable_kernel_rules.txt for the full list. > If so, could you apply 12dd7ecf2323 to linux-3.14.y? > > Apprently, we've had this patch locally since 2012, > but no one cared to push it upstream :-( > > commit 12dd7ecf2323c572b1d302707eada4900848dced > Author: Kees Cook > Date: Thu May 1 14:15:02 2014 -0700 > > lockd: avoid warning when CONFIG_SYSCTL undefined > > When building without CONFIG_SYSCTL, the compiler saw an unused > label. This moves the label into the #ifdef it is used under. > > fs/lockd/svc.c: In function ‘init_nlm’: > fs/lockd/svc.c:626:1: warning: label ‘err_sysctl’ defined but not used [-Wunused-label] Everyone who really uses the kernel enables CONFIG_SYSCTL, so I don't see this being something that is worth adding to the tree. thanks, greg k-h