From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39600 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbbGaRcW (ORCPT ); Fri, 31 Jul 2015 13:32:22 -0400 Date: Fri, 31 Jul 2015 10:32:21 -0700 From: Greg Kroah-Hartman To: Mimi Zohar Cc: Guenter Roeck , stable Subject: Re: Build failures in 3.{10,14}-stable-queue Message-ID: <20150731173221.GA15875@kroah.com> References: <55BA2BC2.3070903@roeck-us.net> <20150730165408.GA5515@kroah.com> <55BAD41F.8030907@roeck-us.net> <20150731035028.GA9589@kroah.com> <1438346419.27604.14.camel@linux.vnet.ibm.com> <20150731163606.GA6631@kroah.com> <1438361764.27604.28.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438361764.27604.28.camel@linux.vnet.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 31, 2015 at 12:56:04PM -0400, Mimi Zohar wrote: > On Fri, 2015-07-31 at 09:36 -0700, Greg Kroah-Hartman wrote: > > On Fri, Jul 31, 2015 at 08:40:19AM -0400, Mimi Zohar wrote: > > > On Thu, 2015-07-30 at 20:50 -0700, Greg Kroah-Hartman wrote: > > > > On Thu, Jul 30, 2015 at 06:49:19PM -0700, Guenter Roeck wrote: > > > > > On 07/30/2015 09:54 AM, Greg Kroah-Hartman wrote: > > > > > >On Thu, Jul 30, 2015 at 06:50:58AM -0700, Guenter Roeck wrote: > > > > > >>Various builds are affected. > > > > > >> > > > > > >>drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request': > > > > > >>drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace' > > > > > >>drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared > > > > > >Ugh, my .config was not building that driver, sorry about that, now > > > > > >fixed and pushed out. > > > > > > > > > > > Hi Greg, > > > > > > > > > > there is another failure, 3.14 only as far as I can see. > > > > > > > > > > Building i386:allyesconfig ... failed > > > > > -------------- > > > > > Error log: > > > > > security/integrity/evm/evm_main.c: In function 'evm_protect_xattr': > > > > > security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared > > > > > security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared > > > > > > > > Ugh, I thought I had test-built these properly. > > > > > > > > Mimi, what did I get wrong with this set for 3.14-stable? > > > > > > Sorry, I should have included magic.h in this patch instead of relying > > > on it to be included by some other include. Easy to forget when there > > > are no warnings. > > > > > > Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give > > > init_task a canary", but hasn't been backported to 3.14. evm_main.c > > > includes audit.h, which includes sched.h. > > > > So which patch should be changed to resolve this issue, and what should > > be changed? Can you send me a patch to merge together with another one? > > Oh, "evm: labeling pseudo filesystems exception" has been added to the > 3.14-stable tree" needs to include magic.h. Ok, thanks, now fixed up. greg k-h