From: Willy Tarreau <w@1wt.eu>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: stable <stable@vger.kernel.org>
Subject: Re: [2.6.32 regression] lzo fails crypto self-tests
Date: Sat, 1 Aug 2015 22:26:14 +0200 [thread overview]
Message-ID: <20150801202614.GA22783@1wt.eu> (raw)
In-Reply-To: <1438450414.3225.22.camel@decadent.org.uk>
Hi Ben,
On Sat, Aug 01, 2015 at 06:33:34PM +0100, Ben Hutchings wrote:
> Linux 2.6.32.64 included an update to the lzo compression code. So far
> as I know, there is nothing wrong with it, but it no longer matches the
> test vectors in crypto/testmgr. Please cherry-pick this fix:
>
> commit 0ec7382036922be063b515b2a3f1d6f7a607392c
> Author: Markus F.X.J. Oberhumer <markus@oberhumer.com>
> Date: Sun Oct 14 15:39:04 2012 +0200
>
> crypto: testmgr - update LZO compression test vectors
Noted, thank you for the information. I don't understand much the problem
you spotted since the change only applies to decompression while the patch
above seems to only adjust the compression patterns (I don't know how the
compression tests work though). Also, for the fix to behave differently,
it requires slightly more than 16 million consecutive 255 bytes to trigger
the error path, which the commit above doesn't seem to perform.
But I'm queuing this patch anyway.
Thanks!
Willy
next prev parent reply other threads:[~2015-08-01 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 17:33 [2.6.32 regression] lzo fails crypto self-tests Ben Hutchings
2015-08-01 20:26 ` Willy Tarreau [this message]
2015-08-01 20:40 ` Ben Hutchings
2015-08-01 22:09 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801202614.GA22783@1wt.eu \
--to=w@1wt.eu \
--cc=ben@decadent.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).