From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 5 Aug 2015 23:26:56 -0700 From: Tony Lindgren To: Kishon Vijay Abraham I Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, nsekhar@ti.com, stable@vger.kernel.org, Tero Kristo Subject: Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator Message-ID: <20150806062655.GM16878@atomide.com> References: <1437996250-2913-1-git-send-email-kishon@ti.com> <1437996250-2913-2-git-send-email-kishon@ti.com> <20150805094717.GX16878@atomide.com> <55C2242D.4030703@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C2242D.4030703@ti.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: * Kishon Vijay Abraham I [150805 07:59]: > Hi Tony, > > On Wednesday 05 August 2015 03:17 PM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I [150727 04:27]: > >> vsel_reg and enable_reg of the pbias regulator descriptor should actually > >> have the offset from syscon. However after the pbias device tree node > >> is moved as a child node of syscon, vsel_reg and enable_reg has the > >> absolute address because of the address translation that happens while > >> creating device from device tree node. > >> So avoid using platform_get_resource and use of_get_address in order to > >> get only the offset (untranslated address) and populate these in > >> vsel_reg and enable_reg. > > > > I think this gets fixed automatically with your other series > > adding the "simple-bus" to the nodes. For the children of_ioremap > > Nope. The probe of pbias regulator fails as Grygorii has already pointed out > here [1]. Oh I see, you want the offset from syscon, not the virtual address of the register. Yeah then it makes sense to me. You could also get the offset by doing res->start & 0xff or something but I don't know if that's any better. I guess ideallly we'd have some syscon function to get the offest from the syscon base if it does not exist already. Regards, Tony > [1] -> http://www.spinics.net/lists/linux-omap/msg120462.html