* mmc: sdhci: Fix FSL ESDHC reset handling quirk
@ 2015-06-02 14:37 Jakub Kicinski
2015-06-03 0:46 ` Greg KH
2015-08-10 16:27 ` Luis Henriques
0 siblings, 2 replies; 7+ messages in thread
From: Jakub Kicinski @ 2015-06-02 14:37 UTC (permalink / raw)
To: stable
Please include following patch from Linus' tree in the 3.18 branch.
Without it SDHC is unusable on Freescale P2020. Thanks!
commit 556b5f33513f16450e8bb803c82a24377b94a34e
From: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Date: Tue, 9 Dec 2014 09:40:38 +0100
mmc: sdhci: Fix FSL ESDHC reset handling quirk
The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
esdhc code") states that Freescale esdhc is the only controller which needs
the interrupt registers restored after a reset. So it moves
SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
esdhc-imx driver only. Unfortunately the same controller is used in
other boards which use the of-esdhc driver instead (like powerpc P2020).
Restore interrupts after reset in the sdhci-of-esdhc driver also.
Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-of-esdhc.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-06-02 14:37 mmc: sdhci: Fix FSL ESDHC reset handling quirk Jakub Kicinski
@ 2015-06-03 0:46 ` Greg KH
2015-06-03 4:54 ` Jakub Kicinski
2015-08-10 16:27 ` Luis Henriques
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-06-03 0:46 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: stable
On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> Please include following patch from Linus' tree in the 3.18 branch.
> Without it SDHC is unusable on Freescale P2020. Thanks!
>
>
> commit 556b5f33513f16450e8bb803c82a24377b94a34e
I don't see this commit anywhere in Linus's tree. Where did you find
it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-06-03 0:46 ` Greg KH
@ 2015-06-03 4:54 ` Jakub Kicinski
2015-07-31 1:07 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2015-06-03 4:54 UTC (permalink / raw)
To: Greg KH; +Cc: stable
On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote:
> On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> > Please include following patch from Linus' tree in the 3.18 branch.
> > Without it SDHC is unusable on Freescale P2020. Thanks!
> >
> >
> > commit 556b5f33513f16450e8bb803c82a24377b94a34e
>
> I don't see this commit anywhere in Linus's tree. Where did you find
> it?
Argh, stupidly I sent you the commit id from after I applied this to
3.18... In Linus's tree it's 304f0a98d168, sorry.
commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Date: Tue Dec 9 09:40:38 2014 +0100
mmc: sdhci: Fix FSL ESDHC reset handling quirk
The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
esdhc code") states that Freescale esdhc is the only controller which needs
the interrupt registers restored after a reset. So it moves
SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
esdhc-imx driver only. Unfortunately the same controller is used in
other boards which use the of-esdhc driver instead (like powerpc P2020).
Restore interrupts after reset in the sdhci-of-esdhc driver also.
Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-06-03 4:54 ` Jakub Kicinski
@ 2015-07-31 1:07 ` Greg KH
2015-07-31 10:53 ` Jakub Kicinski
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-07-31 1:07 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: stable
On Wed, Jun 03, 2015 at 06:54:38AM +0200, Jakub Kicinski wrote:
> On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote:
> > On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> > > Please include following patch from Linus' tree in the 3.18 branch.
> > > Without it SDHC is unusable on Freescale P2020. Thanks!
> > >
> > >
> > > commit 556b5f33513f16450e8bb803c82a24377b94a34e
> >
> > I don't see this commit anywhere in Linus's tree. Where did you find
> > it?
>
> Argh, stupidly I sent you the commit id from after I applied this to
> 3.18... In Linus's tree it's 304f0a98d168, sorry.
>
>
> commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
> Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Date: Tue Dec 9 09:40:38 2014 +0100
>
> mmc: sdhci: Fix FSL ESDHC reset handling quirk
>
> The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> esdhc code") states that Freescale esdhc is the only controller which needs
> the interrupt registers restored after a reset. So it moves
> SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> esdhc-imx driver only. Unfortunately the same controller is used in
> other boards which use the of-esdhc driver instead (like powerpc P2020).
>
> Restore interrupts after reset in the sdhci-of-esdhc driver also.
>
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
I don't remember tree what you wanted this applied to, so I tried
3.14-stable, and that didn't work. Can you be more specific?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-07-31 1:07 ` Greg KH
@ 2015-07-31 10:53 ` Jakub Kicinski
2015-07-31 16:37 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2015-07-31 10:53 UTC (permalink / raw)
To: Greg KH; +Cc: stable
On Thu, 30 Jul 2015 18:07:39 -0700, Greg KH wrote:
> On Wed, Jun 03, 2015 at 06:54:38AM +0200, Jakub Kicinski wrote:
> > On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote:
> > > On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> > > > Please include following patch from Linus' tree in the 3.18 branch.
> > > > Without it SDHC is unusable on Freescale P2020. Thanks!
> > > >
> > > >
> > > > commit 556b5f33513f16450e8bb803c82a24377b94a34e
> > >
> > > I don't see this commit anywhere in Linus's tree. Where did you find
> > > it?
> >
> > Argh, stupidly I sent you the commit id from after I applied this to
> > 3.18... In Linus's tree it's 304f0a98d168, sorry.
> >
> >
> > commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
> > Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > Date: Tue Dec 9 09:40:38 2014 +0100
> >
> > mmc: sdhci: Fix FSL ESDHC reset handling quirk
> >
> > The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> > esdhc code") states that Freescale esdhc is the only controller which needs
> > the interrupt registers restored after a reset. So it moves
> > SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> > esdhc-imx driver only. Unfortunately the same controller is used in
> > other boards which use the of-esdhc driver instead (like powerpc P2020).
> >
> > Restore interrupts after reset in the sdhci-of-esdhc driver also.
> >
> > Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
>
> I don't remember tree what you wanted this applied to, so I tried
> 3.14-stable, and that didn't work. Can you be more specific?
OK, let me try again. I would like the following commit to be applied
to 3.18:
commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Date: Tue Dec 9 09:40:38 2014 +0100
mmc: sdhci: Fix FSL ESDHC reset handling quirk
The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
esdhc code") states that Freescale esdhc is the only controller which needs
the interrupt registers restored after a reset. So it moves
SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
esdhc-imx driver only. Unfortunately the same controller is used in
other boards which use the of-esdhc driver instead (like powerpc P2020).
Restore interrupts after reset in the sdhci-of-esdhc driver also.
Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-07-31 10:53 ` Jakub Kicinski
@ 2015-07-31 16:37 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-07-31 16:37 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: stable
On Fri, Jul 31, 2015 at 12:53:31PM +0200, Jakub Kicinski wrote:
> On Thu, 30 Jul 2015 18:07:39 -0700, Greg KH wrote:
> > On Wed, Jun 03, 2015 at 06:54:38AM +0200, Jakub Kicinski wrote:
> > > On Wed, 3 Jun 2015 09:46:29 +0900, Greg KH wrote:
> > > > On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> > > > > Please include following patch from Linus' tree in the 3.18 branch.
> > > > > Without it SDHC is unusable on Freescale P2020. Thanks!
> > > > >
> > > > >
> > > > > commit 556b5f33513f16450e8bb803c82a24377b94a34e
> > > >
> > > > I don't see this commit anywhere in Linus's tree. Where did you find
> > > > it?
> > >
> > > Argh, stupidly I sent you the commit id from after I applied this to
> > > 3.18... In Linus's tree it's 304f0a98d168, sorry.
> > >
> > >
> > > commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
> > > Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > > Date: Tue Dec 9 09:40:38 2014 +0100
> > >
> > > mmc: sdhci: Fix FSL ESDHC reset handling quirk
> > >
> > > The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> > > esdhc code") states that Freescale esdhc is the only controller which needs
> > > the interrupt registers restored after a reset. So it moves
> > > SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> > > esdhc-imx driver only. Unfortunately the same controller is used in
> > > other boards which use the of-esdhc driver instead (like powerpc P2020).
> > >
> > > Restore interrupts after reset in the sdhci-of-esdhc driver also.
> > >
> > > Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> >
> > I don't remember tree what you wanted this applied to, so I tried
> > 3.14-stable, and that didn't work. Can you be more specific?
>
> OK, let me try again. I would like the following commit to be applied
> to 3.18:
>
>
> commit 304f0a98d168563b5f69c53a7544c36e6d221ac4
> Author: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Date: Tue Dec 9 09:40:38 2014 +0100
>
> mmc: sdhci: Fix FSL ESDHC reset handling quirk
>
> The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> esdhc code") states that Freescale esdhc is the only controller which needs
> the interrupt registers restored after a reset. So it moves
> SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> esdhc-imx driver only. Unfortunately the same controller is used in
> other boards which use the of-esdhc driver instead (like powerpc P2020).
>
> Restore interrupts after reset in the sdhci-of-esdhc driver also.
>
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
As I don't maintain 3.18, nothing I can do here, great! :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mmc: sdhci: Fix FSL ESDHC reset handling quirk
2015-06-02 14:37 mmc: sdhci: Fix FSL ESDHC reset handling quirk Jakub Kicinski
2015-06-03 0:46 ` Greg KH
@ 2015-08-10 16:27 ` Luis Henriques
1 sibling, 0 replies; 7+ messages in thread
From: Luis Henriques @ 2015-08-10 16:27 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: stable
On Tue, Jun 02, 2015 at 04:37:09PM +0200, Jakub Kicinski wrote:
> Please include following patch from Linus' tree in the 3.18 branch.
> Without it SDHC is unusable on Freescale P2020. Thanks!
>
It looks like this fix is also applicable to the 3.16 kernel. I'll
queue it for the next release.
Cheers,
--
Lu�s
>
> commit 556b5f33513f16450e8bb803c82a24377b94a34e
> From: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Date: Tue, 9 Dec 2014 09:40:38 +0100
>
> mmc: sdhci: Fix FSL ESDHC reset handling quirk
>
> The commit 0718e59ae259 ("mmc: sdhci: move FSL ESDHC reset handling quirk into
> esdhc code") states that Freescale esdhc is the only controller which needs
> the interrupt registers restored after a reset. So it moves
> SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET quirk handling code into the
> esdhc-imx driver only. Unfortunately the same controller is used in
> other boards which use the of-esdhc driver instead (like powerpc P2020).
>
> Restore interrupts after reset in the sdhci-of-esdhc driver also.
>
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> drivers/mmc/host/sdhci-of-esdhc.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-10 16:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-02 14:37 mmc: sdhci: Fix FSL ESDHC reset handling quirk Jakub Kicinski
2015-06-03 0:46 ` Greg KH
2015-06-03 4:54 ` Jakub Kicinski
2015-07-31 1:07 ` Greg KH
2015-07-31 10:53 ` Jakub Kicinski
2015-07-31 16:37 ` Greg KH
2015-08-10 16:27 ` Luis Henriques
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).