stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Hugh Dickins <hughd@google.com>,
	kernel@kyup.com, torvalds@linux-foundation.org,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] mm, vmscan: Do not wait for page writeback for GFP_NOFS" failed to apply to 4.1-stable tree
Date: Fri, 14 Aug 2015 10:33:54 -0700	[thread overview]
Message-ID: <20150814173354.GB4125@kroah.com> (raw)
In-Reply-To: <20150814070037.GB32091@dhcp22.suse.cz>

On Fri, Aug 14, 2015 at 09:00:37AM +0200, Michal Hocko wrote:
> On Thu 13-08-15 19:35:03, Greg KH wrote:
> > On Thu, Aug 13, 2015 at 04:24:10PM -0700, Hugh Dickins wrote:
> > > On Thu, 13 Aug 2015, gregkh@linuxfoundation.org wrote:
> > > > 
> > > > The patch below does not apply to the 4.1-stable tree.
> > > > If someone wants it applied there, or to any other stable or longterm
> > > > tree, then please email the backport, including the original git commit
> > > > id to <stable@vger.kernel.org>.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > ------------ commit in Linus's tree adjusted to 4.1.5 -------------
> > 
> > Thanks for this.  Should it also be backported to older kernels as well?
> 
> Yes 3.9+ would be appreciated as per Hugh's testing 
> http://lkml.kernel.org/r/alpine.LSU.2.11.1508032227050.5070%40eggly.anvils
> "
> And more testing on the history of it, considering your stable 3.6+
> designation that I wasn't satisfied with.  Getting out that USB stick
> again, I find that 3.6, 3.7 and 3.8 all OOM if their __GFP_IO test
> is updated to a may_enter_fs test; but something happened in 3.9
> to make it and subsequent releases safe with the may_enter_fs test.
> You can certainly argue that the remote chance of a deadlock is
> worse than the fair chance of a spurious OOM; but if you insist
> on 3.6+, then I think it would have to go back even further,
> because we marked that commit for stable itself.  I suggest 3.9+.
> "

Ok, I've applied this to 3.10 and 3.14-stable trees.  For 3.10, it had
to be done by hand, so if you could verify I got it right, that would be
appreciated (the whole comment block change didn't apply, but the if()
change did.)

thanks,

greg k-h

  reply	other threads:[~2015-08-14 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 22:26 FAILED: patch "[PATCH] mm, vmscan: Do not wait for page writeback for GFP_NOFS" failed to apply to 4.1-stable tree gregkh
2015-08-13 23:24 ` Hugh Dickins
2015-08-14  2:35   ` Greg KH
2015-08-14  7:00     ` Michal Hocko
2015-08-14 17:33       ` Greg KH [this message]
2015-08-14 18:40         ` Hugh Dickins
2015-08-25 10:57   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150814173354.GB4125@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=kernel@kyup.com \
    --cc=mhocko@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).