From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Eli Cohen <eli@mellanox.com>,
linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes
Date: Wed, 19 Aug 2015 11:46:14 -0600 [thread overview]
Message-ID: <20150819174614.GC22646@obsidianresearch.com> (raw)
In-Reply-To: <1440002254-795-2-git-send-email-hch@lst.de>
On Wed, Aug 19, 2015 at 06:37:32PM +0200, Christoph Hellwig wrote:
> We have many WR opcodes that are only supported in kernel space
> and/or require optional information to be copied into the WR
> structure. Reject all those not explicitly handled so that we
> can't pass invalid information to drivers.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> drivers/infiniband/core/uverbs_cmd.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Oh yes, this is absolutely needed for -stable.
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
AFAIK, this path is rarely (never?) actually used. I think all the
drivers we have can post directly from userspace.
Jason
next prev parent reply other threads:[~2015-08-19 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440002254-795-1-git-send-email-hch@lst.de>
2015-08-19 16:37 ` [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes Christoph Hellwig
2015-08-19 17:46 ` Jason Gunthorpe [this message]
2015-08-19 17:48 ` Christoph Hellwig
2015-08-19 17:54 ` Jason Gunthorpe
2015-08-20 8:49 ` Sagi Grimberg
2015-08-20 22:30 ` Steve Wise
2015-08-19 19:50 ` Hefty, Sean
2015-08-20 9:22 ` Christoph Hellwig
2015-08-20 8:52 ` Sagi Grimberg
2015-08-22 6:38 ` Haggai Eran
2015-08-22 8:25 ` Christoph Hellwig
2015-08-24 6:52 ` Haggai Eran
2015-08-24 6:55 ` Christoph Hellwig
2015-08-24 7:59 ` Haggai Eran
2015-08-25 8:55 ` Christoph Hellwig
[not found] <1440579639-10684-1-git-send-email-hch@lst.de>
2015-08-26 9:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819174614.GC22646@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=hch@lst.de \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).