From: Ralf Baechle <ralf@linux-mips.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Alban Bedel <albeu@free.fr>,
linux-mips@linux-mips.org,
Andrew Bresticker <abrestic@chromium.org>,
Qais Yousef <qais.yousef@imgtec.com>,
Wolfram Sang <wsa@the-dreams.de>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Gabor Juhos <juhosg@openwrt.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API
Date: Wed, 19 Aug 2015 23:03:30 +0200 [thread overview]
Message-ID: <20150819210330.GO3612@linux-mips.org> (raw)
In-Reply-To: <55C745B7.3040002@hauke-m.de>
On Sun, Aug 09, 2015 at 02:21:11PM +0200, Hauke Mehrtens wrote:
> Date: Sun, 09 Aug 2015 14:21:11 +0200
> From: Hauke Mehrtens <hauke@hauke-m.de>
> To: Alban Bedel <albeu@free.fr>, linux-mips@linux-mips.org, Ralf Baechle
> <ralf@linux-mips.org>
> CC: Andrew Bresticker <abrestic@chromium.org>, Qais Yousef
> <qais.yousef@imgtec.com>, Wolfram Sang <wsa@the-dreams.de>, Sergey
> Ryazanov <ryazanov.s.a@gmail.com>, Gabor Juhos <juhosg@openwrt.org>,
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API
> Content-Type: text/plain; charset=windows-1252
>
> On 04/19/2015 02:30 PM, Alban Bedel wrote:
> > Make the code simpler and open the way for device tree clocks.
> >
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> > ---
> > arch/mips/Kconfig | 1 +
> > arch/mips/ath79/clock.c | 29 ++---------------------------
> > 2 files changed, 3 insertions(+), 27 deletions(-)
> >
>
> I think this should be send at least to stable 4.1, because it fixes a
> linking problem we are seeing in OpenWrt.
>
> ath79 does not export clk_set_rate() and clk_round_rate(), but some
> drivers are using it and they are not using the inline dummy method,
> because CONFIG_HAVE_CLK is set for ath79.
>
> ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined!
> ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
> ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
Ok. Will post the the patch in a separate email.
Ralf
next parent reply other threads:[~2015-08-19 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1429446604-15403-1-git-send-email-albeu@free.fr>
[not found] ` <1429446604-15403-6-git-send-email-albeu@free.fr>
[not found] ` <55C745B7.3040002@hauke-m.de>
2015-08-19 21:03 ` Ralf Baechle [this message]
2015-08-19 21:10 ` MIPS: ath79: Use the common clk API Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819210330.GO3612@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=abrestic@chromium.org \
--cc=albeu@free.fr \
--cc=hauke@hauke-m.de \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=qais.yousef@imgtec.com \
--cc=ryazanov.s.a@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).