From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward-corp1g.mail.yandex.net ([95.108.253.251]:53881 "EHLO forward-corp1g.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbbHXM5X (ORCPT ); Mon, 24 Aug 2015 08:57:23 -0400 Subject: [PATCH RESEND 2/2] ovl: free lower_mnt array in ovl_put_super From: Konstantin Khlebnikov To: Al Viro , Miklos Szeredi Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-unionfs@vger.kernel.org Date: Mon, 24 Aug 2015 15:57:19 +0300 Message-ID: <20150824125719.6218.68404.stgit@buzz> In-Reply-To: <20150824125718.6218.9443.stgit@buzz> References: <20150824125718.6218.9443.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: This fixes memory leak after umount. Kmemleak report: unreferenced object 0xffff8800ba791010 (size 8): comm "mount", pid 2394, jiffies 4294996294 (age 53.920s) hex dump (first 8 bytes): 20 1c 13 02 00 88 ff ff ....... backtrace: [] create_object+0x124/0x2c0 [] kmemleak_alloc+0x7b/0xc0 [] __kmalloc+0x106/0x340 [] ovl_fill_super+0x55c/0x9b0 [overlay] [] mount_nodev+0x54/0xa0 [] ovl_mount+0x18/0x20 [overlay] [] mount_fs+0x43/0x170 [] vfs_kern_mount+0x74/0x170 [] do_mount+0x22d/0xdf0 [] SyS_mount+0x7b/0xc0 [] entry_SYSCALL_64_fastpath+0x12/0x76 [] 0xffffffffffffffff Signed-off-by: Konstantin Khlebnikov Fixes: dd662667e6d3 ("ovl: add mutli-layer infrastructure") Cc: stable@vger.kernel.org # v4.0 --- fs/overlayfs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 3f90c43c3c4a..8d04b86e0680 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -544,6 +544,7 @@ static void ovl_put_super(struct super_block *sb) mntput(ufs->upper_mnt); for (i = 0; i < ufs->numlower; i++) mntput(ufs->lower_mnt[i]); + kfree(ufs->lower_mnt); kfree(ufs->config.lowerdir); kfree(ufs->config.upperdir);