From: Christoph Hellwig <hch@lst.de>
To: Haggai Eran <haggaie@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Eli Cohen <eli@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes
Date: Tue, 25 Aug 2015 10:55:08 +0200 [thread overview]
Message-ID: <20150825085508.GC31630@lst.de> (raw)
In-Reply-To: <55DACED9.4060603@mellanox.com>
On Mon, Aug 24, 2015 at 10:59:21AM +0300, Haggai Eran wrote:
> > It looks odd to me as well, but it's not really something I want to
> > change in this series. Note that sparse annoted types like __be32
> > aren't really common in userspace, but with a bit of effort they can
> > be supported. We have them and regularly run sparse for xfsprogs for
> > example.
>
> I have to try it with libibverbs sometime. It doesn't use uapi yet
> though IIRC - it has its own version of the header files.
Yes, I noticed that. And the WR opcodes aren't even exported in the
uapi header, and use a shared namespace with the in-kernel only ones.
It's all a giant mess unfortunately.
next prev parent reply other threads:[~2015-08-25 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440002254-795-1-git-send-email-hch@lst.de>
2015-08-19 16:37 ` [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes Christoph Hellwig
2015-08-19 17:46 ` Jason Gunthorpe
2015-08-19 17:48 ` Christoph Hellwig
2015-08-19 17:54 ` Jason Gunthorpe
2015-08-20 8:49 ` Sagi Grimberg
2015-08-20 22:30 ` Steve Wise
2015-08-19 19:50 ` Hefty, Sean
2015-08-20 9:22 ` Christoph Hellwig
2015-08-20 8:52 ` Sagi Grimberg
2015-08-22 6:38 ` Haggai Eran
2015-08-22 8:25 ` Christoph Hellwig
2015-08-24 6:52 ` Haggai Eran
2015-08-24 6:55 ` Christoph Hellwig
2015-08-24 7:59 ` Haggai Eran
2015-08-25 8:55 ` Christoph Hellwig [this message]
[not found] <1440579639-10684-1-git-send-email-hch@lst.de>
2015-08-26 9:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825085508.GC31630@lst.de \
--to=hch@lst.de \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
--cc=sean.hefty@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).