Requesting inclusion of mtd/nand patches in linux-3.14.y

Requesting inclusion of mtd/nand patches in linux-3.14.y

[Mason]

Hello everyone,

This is my second time requesting inclusion of a patch, please
point out any breach of protocol :-)

I have cherry-picked two mtd/nand patches on my local branch
of linux-3.14.y and I realized that these fixes might benefit
other users. (As far as I can tell, they landed in 3.15)

bd9c6e99b582 mtd: nand: don't use read_buf for 8-bit ONFI transfers
60c3bc1fd6f1 mtd: nand: fix erroneous read_buf call in nand_write_page_raw_syndrome


commit 60c3bc1fd6f1fa40b415ef5b83e2948a89a3d79c
Author: Boris BREZILLON <b.brezillon.dev@gmail.com>
Date:   Sat Feb 1 19:10:28 2014 +0100

    mtd: nand: fix erroneous read_buf call in nand_write_page_raw_syndrome
    
    read_buf is called in place of write_buf in the
    nand_write_page_raw_syndrome function.
    
    Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
    Signed-off-by: Brian Norris <computersforpeace@gmail.com>

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 79ed8ccf5065..3cb1cefcd926 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2002,7 +2002,7 @@ static int nand_write_page_raw_syndrome(struct mtd_info *mtd,
                        oob += chip->ecc.prepad;
                }
 
-               chip->read_buf(mtd, oob, eccbytes);
+               chip->write_buf(mtd, oob, eccbytes);
                oob += eccbytes;
 
                if (chip->ecc.postpad) {



commit bd9c6e99b58255b9de1982711ac9487c9a2f18be
Author: Brian Norris <computersforpeace@gmail.com>
Date:   Fri Nov 29 22:04:28 2013 -0800

    mtd: nand: don't use read_buf for 8-bit ONFI transfers
    
    Use a repeated read_byte() instead of read_buf(), since for x16 buswidth
    devices, we need to avoid the upper I/O[16:9] bits. See the following
    commit for reference:
    
    commit 05f7835975dad6b3b517f9e23415985e648fb875
    Author: Uwe Kleine-Kï¿œnig <u.kleine-koenig@pengutronix.de>
    Date:   Thu Dec 5 22:22:04 2013 +0100
    
        mtd: nand: don't use {read,write}_buf for 8-bit transfers
    
    Now, I think that all barriers to probing ONFI on x16 devices are
    removed, so remove the check from nand_flash_detect_onfi().
    
    Tested on 8-bit ONFI NAND (Micron MT29F32G08CBADAWP).
    
    Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
    Tested-By: Pekon Gupta <pekon@ti.com>

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 6281151e4cb7..79ed8ccf5065 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3065,7 +3065,7 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
                                        int *busw)
 {
        struct nand_onfi_params *p = &chip->onfi_params;
-       int i;
+       int i, j;
        int val;
 
        /* Try ONFI for unknown chip or LP */
@@ -3074,18 +3074,10 @@ static int nand_flash_detect_onfi(struct mtd_info *mtd, struct nand_chip *chip,
                chip->read_byte(mtd) != 'F' || chip->read_byte(mtd) != 'I')
                return 0;
 
-       /*
-        * ONFI must be probed in 8-bit mode or with NAND_BUSWIDTH_AUTO, not
-        * with NAND_BUSWIDTH_16
-        */
-       if (chip->options & NAND_BUSWIDTH_16) {
-               pr_err("ONFI cannot be probed in 16-bit mode; aborting\n");
-               return 0;
-       }
-
        chip->cmdfunc(mtd, NAND_CMD_PARAM, 0, -1);
        for (i = 0; i < 3; i++) {
-               chip->read_buf(mtd, (uint8_t *)p, sizeof(*p));
+               for (j = 0; j < sizeof(*p); j++)
+                       ((uint8_t *)p)[j] = chip->read_byte(mtd);
                if (onfi_crc16(ONFI_CRC_BASE, (uint8_t *)p, 254) ==
                                le16_to_cpu(p->crc)) {
                        break;



Regards.

Re: Requesting inclusion of mtd/nand patches in linux-3.14.y

[Greg KH]

On Tue, Jul 28, 2015 at 03:40:46PM +0200, Mason wrote:
> Hello everyone,
> 
> This is my second time requesting inclusion of a patch, please
> point out any breach of protocol :-)

I never saw your first request, where did you send that?

> I have cherry-picked two mtd/nand patches on my local branch
> of linux-3.14.y and I realized that these fixes might benefit
> other users. (As far as I can tell, they landed in 3.15)
> 
> bd9c6e99b582 mtd: nand: don't use read_buf for 8-bit ONFI transfers
> 60c3bc1fd6f1 mtd: nand: fix erroneous read_buf call in nand_write_page_raw_syndrome

both now queued up, thanks.

greg k-h

Re: Requesting inclusion of mtd/nand patches in linux-3.14.y

[Mason]

On 28/07/2015 19:34, Greg KH wrote:

> On Tue, Jul 28, 2015 at 03:40:46PM +0200, Mason wrote:
>
>> This is my second time requesting inclusion of a patch,
>> please point out any breach of protocol :-)
> 
> I never saw your first request, where did you send that?

Sorry Greg, my statement was ambiguous. I didn't mean that
I had already proposed these patches for inclusion. I meant
that today's request is only the second time I have gone
through the process. I made a different request last week
(which was accepted, thanks by the way).

>> I have cherry-picked two mtd/nand patches on my local branch
>> of linux-3.14.y and I realized that these fixes might benefit
>> other users. (As far as I can tell, they landed in 3.15)
>>
>> bd9c6e99b582 mtd: nand: don't use read_buf for 8-bit ONFI transfers
>> 60c3bc1fd6f1 mtd: nand: fix erroneous read_buf call in nand_write_page_raw_syndrome
> 
> both now queued up, thanks.

Thanks to you!

When is 3.14.49 expected, roughly?

Regards.

Re: Requesting inclusion of mtd/nand patches in linux-3.14.y

[Greg KH]

On Tue, Jul 28, 2015 at 10:01:50PM +0200, Mason wrote:
> On 28/07/2015 19:34, Greg KH wrote:
> 
> > On Tue, Jul 28, 2015 at 03:40:46PM +0200, Mason wrote:
> >
> >> This is my second time requesting inclusion of a patch,
> >> please point out any breach of protocol :-)
> > 
> > I never saw your first request, where did you send that?
> 
> Sorry Greg, my statement was ambiguous. I didn't mean that
> I had already proposed these patches for inclusion. I meant
> that today's request is only the second time I have gone
> through the process. I made a different request last week
> (which was accepted, thanks by the way).
> 
> >> I have cherry-picked two mtd/nand patches on my local branch
> >> of linux-3.14.y and I realized that these fixes might benefit
> >> other users. (As far as I can tell, they landed in 3.15)
> >>
> >> bd9c6e99b582 mtd: nand: don't use read_buf for 8-bit ONFI transfers
> >> 60c3bc1fd6f1 mtd: nand: fix erroneous read_buf call in nand_write_page_raw_syndrome
> > 
> > both now queued up, thanks.
> 
> Thanks to you!
> 
> When is 3.14.49 expected, roughly?

When it happens :)

Re: Requesting inclusion of mtd/nand patches in linux-3.14.y

[Brian Norris]

On Tue, Jul 28, 2015 at 10:34:30AM -0700, Greg KH wrote:
> On Tue, Jul 28, 2015 at 03:40:46PM +0200, Mason wrote:
> > This is my second time requesting inclusion of a patch, please
> > point out any breach of protocol :-)
> 
> I never saw your first request, where did you send that?

FWIW, I was just clearing out my nearly-expired spam, and I noticed that
the parent post (apparently Mason's 2nd request?) was sitting in my spam
folder (I thought Greg's response was a little out-of-the-blue...). So,
Gmail didn't like something Mason's email was doing. Not sure if that
could explain problems with Mason's first posting.

Brian