From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:43285 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbbH0NgA (ORCPT ); Thu, 27 Aug 2015 09:36:00 -0400 Date: Thu, 27 Aug 2015 14:35:57 +0100 From: Luis Henriques To: David Miller Cc: stable@vger.kernel.org Subject: Re: [PATCHES] Networking Message-ID: <20150827133557.GB2433@ares> References: <20150826.230512.911383355891074955.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150826.230512.911383355891074955.davem@davemloft.net> Sender: stable-owner@vger.kernel.org List-ID: Hi David, On Wed, Aug 26, 2015 at 11:05:12PM -0700, David Miller wrote: > > Please queue up the following networking bug fixes for v3.12, v3.14, v3.18, > and v4.1 -stable, respectively. > > Thanks! While going through these patches to pick those applicable to the 3.16 kernel, I believe I found an issue with the backport of 1c1bf34951e8 ("net/mlx4_core: Fix wrong index in propagating port change event to VFs") into 3.14. The 2nd hunk has the following: @@ -583,7 +583,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq) for (i = 0; i < dev->num_slaves; i++) { if (i == mlx4_master_func_num(dev)) continue; - s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state; + s_info = &priv->mfunc.master.vf_oper[slave].vport[i].state; It should be: - s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state; + s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; (the 'slave' index should be changed by 'i', not 'port'). Cheers, -- Lu�s