From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"
Date: Mon, 31 Aug 2015 20:25:10 +0300 [thread overview]
Message-ID: <20150831172510.GC29811@intel.com> (raw)
In-Reply-To: <20150831165413.GF31101@saruman.tx.rr.com>
On Mon, Aug 31, 2015 at 11:54:13AM -0500, Felipe Balbi wrote:
> On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> >
> > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4.
> >
> > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out
> > fine, but after a bit of data has been transferred it just stops
> > flowing.
> >
> > Note that I do get a bunch of these "NOHZ: local_softirq_pending 08"
> > when booting the machine, but I'm not really sure if they're related
> > to this problem.
>
> I have a feeling your problem is elsewhere. We *are* completing one TRB
> at a time. By reverting that commit you're just masking the real problem
> and I'd rather get that one fixed.
>
> How do you reproduce your issue ?
Just boot the system, it gets an IP from dnsmasq on my host, then I ssh
into it and do something to produce a bit of console output, after which
g_ether is dead. Eg. 'dmesg' a few times is enough to kill it.
Here's what I have in my .config:
CONFIG_USB_OTG=y
CONFIG_USB_OTG_FSM=y
CONFIG_USB_DWC3=y
CONFIG_USB_DWC3_GADGET=y
CONFIG_USB_DWC3_PCI=y
CONFIG_USB_PHY=y
CONFIG_NOP_USB_XCEIV=y
CONFIG_USB_GPIO_VBUS=y
CONFIG_USB_GADGET=y
CONFIG_USB_GADGET_VBUS_DRAW=2
CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=2
CONFIG_USB_LIBCOMPOSITE=y
CONFIG_USB_U_ETHER=y
CONFIG_USB_F_ECM=y
CONFIG_USB_F_SUBSET=y
CONFIG_USB_ETH=y
--
Ville Syrj�l�
Intel OTC
next prev parent reply other threads:[~2015-08-31 17:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 16:48 [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs" ville.syrjala
2015-08-31 16:54 ` Felipe Balbi
2015-08-31 17:25 ` Ville Syrjälä [this message]
2015-08-31 18:50 ` Felipe Balbi
2015-08-31 18:52 ` Felipe Balbi
2015-09-01 13:17 ` Ville Syrjälä
2015-09-01 13:59 ` Felipe Balbi
2015-09-01 14:39 ` Ville Syrjälä
2015-09-01 15:17 ` Felipe Balbi
2015-09-01 15:37 ` Ville Syrjälä
2015-09-07 6:56 ` Heikki Krogerus
2015-09-28 18:56 ` Ville Syrjälä
2015-09-02 8:09 ` Masakazu Mokuno
2015-09-02 12:29 ` Felipe Balbi
2015-10-12 18:37 ` Felipe Balbi
2015-11-06 12:48 ` Heikki Krogerus
2015-11-06 12:57 ` Heikki Krogerus
2015-11-06 13:31 ` Felipe Balbi
2015-08-31 19:21 ` Sergei Shtylyov
2015-09-01 11:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831172510.GC29811@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).