From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com ([192.94.94.41]:52050 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701AbbIBM3Y (ORCPT ); Wed, 2 Sep 2015 08:29:24 -0400 Date: Wed, 2 Sep 2015 07:29:16 -0500 From: Felipe Balbi To: Masakazu Mokuno CC: , , Greg Kroah-Hartman , , Subject: Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs" Message-ID: <20150902122916.GC7809@saruman.tx.rr.com> Reply-To: References: <1441039708-2504-1-git-send-email-ville.syrjala@linux.intel.com> <20150831165413.GF31101@saruman.tx.rr.com> <20150902170934.C0BB.B02B0EB8@hq.scei.sony.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qjNfmADvan18RZcF" Content-Disposition: inline In-Reply-To: <20150902170934.C0BB.B02B0EB8@hq.scei.sony.co.jp> Sender: stable-owner@vger.kernel.org List-ID: --qjNfmADvan18RZcF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 02, 2015 at 05:09:39PM +0900, Masakazu Mokuno wrote: > Hi, >=20 > On Mon, 31 Aug 2015 11:54:13 -0500 > Felipe Balbi wrote: >=20 > > On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrjala@linux.intel.com= wrote: > > > From: Ville Syrj=E8=88=81=E3=83=BB > > >=20 > > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. > > >=20 > > > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts o= ut > > > fine, but after a bit of data has been transferred it just stops > > > flowing. > > >=20 > > > Note that I do get a bunch of these "NOHZ: local_softirq_pending 08" > > > when booting the machine, but I'm not really sure if they're related > > > to this problem. > >=20 > > I have a feeling your problem is elsewhere. We *are* completing one TRB > > at a time.=20 >=20 > If usb_request.no_interrupt is flagged, it seems dwc3 does not set IOC > on the corresponding TRB. Does it break the assumption every TRB > (without SG) will trigger one corresponding EP event? > u_ether is the function module that utilizes 'no_interrupt' flag. XferInProgress should still trigger. Besides, I tested with the exact same setup (different SoC though), just look at the thread. --=20 balbi --qjNfmADvan18RZcF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV5uucAAoJEIaOsuA1yqREhCgP/0Vqu+Yyv00/Q+40ltdAjrMT 77CeYDEJgBgdHB0eOKso4jCxI4hrCgLU6t+RzBG+sfM9qUrrb+F1+FPLIQEV1BJc 5Oit1Q25Dh68e3HOacm3uoIg5+zZ3Gw6pxkPBS4mOEkD4IoZXFL62uDtKrMmORII L1U6yffrMW6I5UK407yUAP6V5NrcM7L3Aqu3SqkdGgFljXryCY2ZmZgSQ1v/3mTh iuhF8caFFGM3vnb2FO+BNyUqoUxn55jjO358iSRdzAONoGnhcDmcjQQEU57ogWMG t4uWNyD0g//A/I++wzR6bPdNISH7e+mmiAGDPpDwUMT8RR1gDO9gBVntChMoo78X /H1/UoPLnCOEUR3TH1NKJQV4Siau9PWh9SR+/QpOg3pOfmxwkTe8yXCQPxrWeb4L Xx3perIK7iBPY54K1XwH/fvq3alios4Pom1bHYBAftyxG6jFoJ5RG6ftFIRho8/T 6cG2EXLlr7eBvJCxbQg5MoQBf8WDahY2/g38Q46rRvLStDY3vFxz5wl5VWT1xG94 VZZjO6crAILtX3zZHx16fEGaxnH416H7nksNkTfPB8DntefbNtdD0mqsD0CgqdYI 8drhfCCEaxB0NIQnAtS4naRS528K2bUn2Vdczn4S/HXmdyB6E2dEUMO5V472vGA1 300mDl2+75sCqt5z6loV =oFfx -----END PGP SIGNATURE----- --qjNfmADvan18RZcF--