From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:47295 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118AbbINRBJ (ORCPT ); Mon, 14 Sep 2015 13:01:09 -0400 Date: Mon, 14 Sep 2015 18:01:11 +0100 From: Will Deacon To: Marc Zyngier Cc: "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux@arm.linux.org.uk" , "christoffer.dall@linaro.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523 Message-ID: <20150914170111.GH23878@arm.com> References: <1442243163-2675-1-git-send-email-will.deacon@arm.com> <55F6EBD4.30809@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F6EBD4.30809@arm.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 14, 2015 at 04:46:28PM +0100, Marc Zyngier wrote: > On 14/09/15 16:06, Will Deacon wrote: > > When restoring the system register state for an AArch32 guest at EL2, > > writes to DACR32_EL2 may not be correctly synchronised by Cortex-A57, > > which can lead to the guest effectively running with junk in the DACR > > and running into unexpected domain faults. > > > > This patch works around the issue by re-ordering our restoration of the > > AArch32 register aliases so that they happen before the AArch64 system > > registers. Ensuring that the registers are restored in this order > > guarantees that they will be correctly synchronised by the core. > > > > Cc: > > Cc: Marc Zyngier > > Signed-off-by: Will Deacon > > Reviewed-by: Marc Zyngier > > I'll queue that together with the next batch of fixes. Great, thanks Marc. Will