From: Peter Chen <peter.chen@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
USB list <linux-usb@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb
Date: Wed, 16 Sep 2015 10:31:10 +0800 [thread overview]
Message-ID: <20150916023109.GB15736@shlinux2> (raw)
In-Reply-To: <CAOMZO5AJPF2JtuxsRv4xbNPeyp18hNT0MMZbXODBoQmYVPARuQ@mail.gmail.com>
On Wed, Sep 16, 2015 at 12:25:17AM -0300, Fabio Estevam wrote:
> On Tue, Sep 15, 2015 at 10:49 PM, Peter Chen <peter.chen@freescale.com> wrote:
> > For imx27, it needs three clocks to let the controller work,
> > the old code is wrong, and will cause below data abort when
> > accass usbmisc registers.
> >
> > usbcore: registered new interface driver usb-storage
> > Unhandled fault: external abort on non-linefetch (0x008) at 0xf4424600
> > pgd = c0004000
> > [f4424600] *pgd=10000452(bad)
> > Internal error: : 8 [#1] PREEMPT ARM
> > Modules linked in:
> > CPU: 0 PID: 1 Comm: swapper Not tainted 4.1.0-next-20150701-dirty #3089
> > Hardware name: Freescale i.MX27 (Device Tree Support)
> > task: c7832b60 ti: c783e000 task.ti: c783e000
> > PC is at usbmisc_imx27_init+0x4c/0xbc
> > LR is at usbmisc_imx27_init+0x40/0xbc
> > pc : [<c03cb5c0>] lr : [<c03cb5b4>] psr: 60000093
> > sp : c783fe08 ip : 00000000 fp : 00000000
> > r10: c0576434 r9 : 0000009c r8 : c7a773a0
> > r7 : 01000000 r6 : 60000013 r5 : c7a776f0 r4 : c7a773f0
> > r3 : f4424600 r2 : 00000000 r1 : 00000001 r0 : 00000001
> > Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel
> > Control: 0005317f Table: a0004000 DAC: 00000017
> > Process swapper (pid: 1, stack limit = 0xc783e190)
> > Stack: (0xc783fe08 to 0xc7840000)
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: <stable@vger.kernel.org>
> > ---
> > arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++----
> > 1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index feb9d34..93e3e14 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
>
> mx25.dtsi and mx35.dtsi also need to be changed.
>
If you can help to test, I will update.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2015-09-16 3:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442368183-8103-1-git-send-email-peter.chen@freescale.com>
2015-09-16 1:49 ` [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb Peter Chen
2015-09-16 3:25 ` Fabio Estevam
2015-09-16 2:31 ` Peter Chen [this message]
2015-09-16 3:46 ` Fabio Estevam
2015-09-16 4:55 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916023109.GB15736@shlinux2 \
--to=peter.chen@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox