From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Krzysztof Opasiak <k.opasiak@samsung.com>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<andrzej.p@samsung.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation
Date: Wed, 30 Sep 2015 11:15:19 -0500 [thread overview]
Message-ID: <20150930161519.GH32625@saruman.tx.rr.com> (raw)
In-Reply-To: <20150930161152.GG32625@saruman.tx.rr.com>
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Wed, Sep 30, 2015 at 11:11:52AM -0500, Felipe Balbi wrote:
> On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote:
> > Since:
> >
> > commit e0857ce58e8658657f5f12fe25272b93cfeb16aa
>
> this should be something like:
>
> Since commit e0857ce58e86 (" .... ")
>
> > ("usb: gadget: loopback: don't queue requests to bogus endpoints")
> >
> > Loopback function is not realy working as that commit removed
> > all looping back logic. After that commit ep-out works like
> > /dev/null and ep-in works like /dev/zero.
> >
> > This commit fix this issue by allocating set of out requests
> > and set of in requests but each out req shares buffer with
> > one in req:
> >
> > out_req->buf ---> buf <--- in_req.buf
> > out_req->context <---> in_req.context
> >
> > The completion routine simply enqueue the suitable req in
> > an oposite direction.
> >
> > Cc: <stable@vger.kernel.org> # 3.18+
>
> missing Fixes: e0857ce58e86 ("...")
>
> I'll fix both while applying, but make sure to make this proper
> next time.
actually fails to apply to v4.3-rc3, please rebase.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-30 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 18:40 [PATCH v3 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances Krzysztof Opasiak
2015-09-22 18:40 ` [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation Krzysztof Opasiak
2015-09-30 16:11 ` Felipe Balbi
2015-09-30 16:15 ` Felipe Balbi [this message]
2015-10-13 18:11 ` Krzysztof Opasiak
2015-10-13 18:16 ` Felipe Balbi
2015-09-24 15:19 ` [PATCH v3 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances Robert Baldyga
2015-09-24 16:51 ` Felipe Balbi
2015-09-24 17:10 ` Krzysztof Opasiak
2015-09-30 16:08 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930161519.GH32625@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=andrzej.p@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.opasiak@samsung.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox