From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com ([192.94.94.41]:41842 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbbJBTzt (ORCPT ); Fri, 2 Oct 2015 15:55:49 -0400 Date: Fri, 2 Oct 2015 14:55:47 -0500 From: Felipe Balbi To: John Youn CC: "balbi@ti.com" , "linux-usb@vger.kernel.org" , "david.fisher1@synopsys.com" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/6] usb: dwc3: Support Synopsys USB 3.1 IP Message-ID: <20151002195547.GG5552@saruman.tx.rr.com> Reply-To: References: <20151002020355.GB2534@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE30077290901DC384A94@US01WEMBX2.internal.synopsys.com> <2B3535C5ECE8B5419E3ECBE30077290901DC385420@US01WEMBX2.internal.synopsys.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d5ZB48mKYG2jsBgL" Content-Disposition: inline In-Reply-To: <2B3535C5ECE8B5419E3ECBE30077290901DC385420@US01WEMBX2.internal.synopsys.com> Sender: stable-owner@vger.kernel.org List-ID: --d5ZB48mKYG2jsBgL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 02, 2015 at 07:47:24PM +0000, John Youn wrote: > On 10/1/2015 8:09 PM, John Youn wrote: > > On 10/1/2015 7:03 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Fri, Sep 04, 2015 at 07:15:10PM -0700, John Youn wrote: > >>> + > >>> +/* DWC_usb31 revisions */ > >>> +#define DWC3_USB31_REVISION_110A 0x3131302a > >> > >> are you sure you tested this ? Above you check for 0x33310000 but here= you use > >> 0x3131 ? What gives ? Also, it seems odd that revision 1.10a is actual= ly 3.02a > >> in HW, is this really correct ? > >> > >=20 > > The one in the source file is wrong. I did run it but not sure > > how it was working... maybe wrong bitfile. I'll look into it > > and fix it. > >=20 > > The version value is actually ASCII using all 4 > > bytes: "110*". The last 'a' is replaced with '*' in the register > > as that indicates a documentation only change with no IP changes. > >=20 >=20 > Correcting myself, the source is right the first time. >=20 > The reason we check for "3331" in probe is because the 3.1 > core uses GSNPSID strictly as an ID register not a version. >=20 > 3.0 IP: > GSNPSID =3D 0x5533 (ID) + 0x260a (VERSION) >=20 > 3.1 IP: > GSNPSID =3D "33313130" (ID) > VER_NUMBER =3D "3131302a" (VERSION) oh all right, thanks for clarifying. :-) --=20 balbi --d5ZB48mKYG2jsBgL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDuFDAAoJEIaOsuA1yqREa3EP/2lJ4ALiNGcG7ujMG3NAEvyB oM/KMy5MtW/Eo3NuZ3Y8ZUyoaAB5HlipZ4Pg9XPwhfwY3RvUouxJvx4bYp9uWJHr iH2gy4khmCJ2BlqscmP1YqNo2DgKQbqjltwfZ2Asxke8xZbu0ThSEBYZJbhq0Vqs rzXzg9CiQCmR0fPEnltbRkw4vL9FH+v2ZAE2xYeZO3gdrw6hDYpuB0pTQUwHMR4P pmrUaIHGeHcxyxD6xgTop6u/ko5gRYnrrxurgYc9SVIeqrLT8trC5Txs4+Iy/cMv 1XKcvvhgpew6cMBPsTu8GART4rFvASVANUWyY1cyhBkt03dHwAXwfRFT7ZsK+EbJ PeLBTAigCFpwYZTWMMZ1mXGwh2wudIrEOr5ZN2uEfGxewdS+WzeelyJIgHndQeHS ke8xVa+42ZfvZb20cYmSLqJveoveBljNvbWrrsmGNfRhOE8I/agzGBkpXcXIvyhk DyaoebQiv/jkWZSjB0H1pTYJHVXr2wvCTE6WLrPo2KpbChPt0bXR/tohqofkWaAI iY4rNCtxv0x0HBxXqOWTwkcIPF+mGto7eQhaqwt62hLDiKY/WoL25Gw0mem/qmcY hdd8YQeezg7Yj605kwdHKjr7Ma99wQmU2UB4iRdtQ3IVPmPKrxXj0z8qgKV92jh7 nObpVDZW+CgcdBHIb8TE =WbVF -----END PGP SIGNATURE----- --d5ZB48mKYG2jsBgL--