Re: [PATCH 1/6] usb: dwc3: Support Synopsys USB 3.1 IP

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Oct 03, 2015 at 01:14:27AM +0000, John Youn wrote:
> On 10/2/2015 5:33 PM, Felipe Balbi wrote:
> > On Sat, Oct 03, 2015 at 12:02:54AM +0200, Greg KH wrote:
> >> On Fri, Oct 02, 2015 at 02:21:01PM -0500, Felipe Balbi wrote:
> >>>> We're trying to avoid the situation where where we have to ship
> >>>> patches or maintain a separate kernel tree.
> >>>>
> >>>> Do you have any objections to these going into stable?
> >>>
> >>> I'm not the one you need to convince. That would be Greg :-)
> >>
> >> What's the git commit id of the patch in Linus's tree?
> > 
> > the patch doesn't exist yet. John sent a series wich I don't feel it fits
> > stable. The new device IDs, sure, but all the other changes which, granted, are
> > related, but don't seem like stable material IMO.
> > 
> > For reference, here are all the patches:
> > 
> > http://www.spinics.net/lists/linux-usb/msg130712.html
> > http://www.spinics.net/lists/linux-usb/msg130711.html
> > http://www.spinics.net/lists/linux-usb/msg130717.html
> > http://www.spinics.net/lists/linux-usb/msg130713.html
> > http://www.spinics.net/lists/linux-usb/msg130716.html
> > http://www.spinics.net/lists/linux-usb/msg130714.html
> > 
> 
> Hi Greg,
> 
> I'm in the process of simplifying and resubmitting these.
> 
> But to summarize, these are all small changes to get newer
> hardware to work with older drivers and to address failures
> with certain hardware for compliance testing.
> 
> Patch 1 allows the dwc3 driver to work with newer hardware. An ID
> register in the hardware has changed causing the probe to
> fail. And we ensure the new version numbers are higher than
> older versions.
> 
> Patch 2-3 adds PCI Device IDs so that dwc3 will load with various
> versions of our hardware.
> 
> Patch 4 adds the correct driver parameters for our hardware.
> 
> Patch 5 adds a quirk for a problem with some PHYs.
> 
> Patch 6 is not tagged for stable (formatting only).
> 
> Are these kind of changes appropriate for stable?

Read Documentation/stable_kernel_rules.txt and you tell me.  I'm not
going to dig up the web links at the moment, sorry, as I have over 400
patches in my queue to work on to be applied to the stable trees that
are already in Linus's tree.  Let me work on those now, instead of
hypothetical ones that have not been accepted yet :)

> The reason we want them in stable is because we have some
> products that are stuck on 3.18 currently and later will be
> updated to 4.2.

Then submit them properly, and when they are in Linus's tree, I'll get
notified of them and if I think they are not acceptable, I'll let you
know.

thanks,

greg k-h