From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from down.free-electrons.com ([37.187.137.238]:42092 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753616AbbJGLBr (ORCPT ); Wed, 7 Oct 2015 07:01:47 -0400 Date: Wed, 7 Oct 2015 13:01:12 +0200 From: Alexandre Belloni To: Sylvain Rochet Cc: Guenter Roeck , Boris BREZILLON , linux-kernel@vger.kernel.org, Nicolas Ferre , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode Message-ID: <20151007110112.GD3485@piout.net> References: <1444163325-3041-1-git-send-email-sylvain.rochet@finsecur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444163325-3041-1-git-send-email-sylvain.rochet@finsecur.com> Sender: stable-owner@vger.kernel.org List-ID: Hi Sylvain, On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote : > Since turning on idle-halt in commit 5161b31dc39a (watchdog: > at91sam9_wdt: better watchdog support"), SoCs compatible with > at91sam9260-wdt not using a device tree no longer reboot if the watchdog > times out while the CPU is in idle state. Removing the > AT91_WDT_WDIDLEHLT flag that was set by default fixes this. > > Signed-off-by: Sylvain Rochet > Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support") > Cc: # 3.14+ Acked-by: Alexandre Belloni However, we don't really care about that for kernels after 3.18 as no users are using pdata anymore. I think you could send a follow-up patch removing pdata support completely. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com