stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Build failure in v3.14-stable-queue (hexagon:defconfig)
@ 2015-10-15  0:54 Guenter Roeck
  2015-10-15 17:28 ` Richard Kuo
  2015-10-15 18:05 ` Richard Kuo
  0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2015-10-15  0:54 UTC (permalink / raw)
  To: stable, Greg Kroah-Hartman, Richard Kuo

Building hexagon:defconfig ... failed
--------------
Error log:

In file included from kernel/sched/core.c:85:0:
kernel/sched/sched.h: In function 'finish_lock_switch':
kernel/sched/sched.h:1000:2: error: implicit declaration of function 'smp_store_release' [-Werror=implicit-function-declaration]

Caused by 'sched/core: Fix TASK_DEAD race in finish_task_switch()'.

Richard, any idea how to fix this ?

Guenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Build failure in v3.14-stable-queue (hexagon:defconfig)
  2015-10-15  0:54 Build failure in v3.14-stable-queue (hexagon:defconfig) Guenter Roeck
@ 2015-10-15 17:28 ` Richard Kuo
  2015-10-15 18:05 ` Richard Kuo
  1 sibling, 0 replies; 4+ messages in thread
From: Richard Kuo @ 2015-10-15 17:28 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: stable, Greg Kroah-Hartman

On Wed, Oct 14, 2015 at 05:54:23PM -0700, Guenter Roeck wrote:
> Building hexagon:defconfig ... failed
> --------------
> Error log:
> 
> In file included from kernel/sched/core.c:85:0:
> kernel/sched/sched.h: In function 'finish_lock_switch':
> kernel/sched/sched.h:1000:2: error: implicit declaration of function 'smp_store_release' [-Werror=implicit-function-declaration]
> 
> Caused by 'sched/core: Fix TASK_DEAD race in finish_task_switch()'.
> 
> Richard, any idea how to fix this ?
> 
> Guenter

Hexagon doesn't have that defined, so it should come from generic.

The Kbuild line for that was added:

f549ed1a (Stephen Rothwell 2014-01-14 16:36:10 +1100  5) generic-y += barrier.h

That's as far as I know.  This is against v3.14?  I can take a look at it...


Thanks,
Richard Kuo



-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Build failure in v3.14-stable-queue (hexagon:defconfig)
  2015-10-15  0:54 Build failure in v3.14-stable-queue (hexagon:defconfig) Guenter Roeck
  2015-10-15 17:28 ` Richard Kuo
@ 2015-10-15 18:05 ` Richard Kuo
  2015-10-17 23:24   ` Greg Kroah-Hartman
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Kuo @ 2015-10-15 18:05 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: stable, Greg Kroah-Hartman

On Wed, Oct 14, 2015 at 05:54:23PM -0700, Guenter Roeck wrote:
> Building hexagon:defconfig ... failed
> --------------
> Error log:
> 
> In file included from kernel/sched/core.c:85:0:
> kernel/sched/sched.h: In function 'finish_lock_switch':
> kernel/sched/sched.h:1000:2: error: implicit declaration of function 'smp_store_release' [-Werror=implicit-function-declaration]
> 
> Caused by 'sched/core: Fix TASK_DEAD race in finish_task_switch()'.
> 
> Richard, any idea how to fix this ?
> 
> Guenter

I think the extra barrier includes were fixed in:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=94cf42f823bc904305b0ee93a09bcd51ba380497




-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Build failure in v3.14-stable-queue (hexagon:defconfig)
  2015-10-15 18:05 ` Richard Kuo
@ 2015-10-17 23:24   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2015-10-17 23:24 UTC (permalink / raw)
  To: Richard Kuo; +Cc: Guenter Roeck, stable

On Thu, Oct 15, 2015 at 01:05:37PM -0500, Richard Kuo wrote:
> On Wed, Oct 14, 2015 at 05:54:23PM -0700, Guenter Roeck wrote:
> > Building hexagon:defconfig ... failed
> > --------------
> > Error log:
> > 
> > In file included from kernel/sched/core.c:85:0:
> > kernel/sched/sched.h: In function 'finish_lock_switch':
> > kernel/sched/sched.h:1000:2: error: implicit declaration of function 'smp_store_release' [-Werror=implicit-function-declaration]
> > 
> > Caused by 'sched/core: Fix TASK_DEAD race in finish_task_switch()'.
> > 
> > Richard, any idea how to fix this ?
> > 
> > Guenter
> 
> I think the extra barrier includes were fixed in:
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=94cf42f823bc904305b0ee93a09bcd51ba380497

Ok, I've queued this patch up now, let's see what happens...


thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-17 23:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15  0:54 Build failure in v3.14-stable-queue (hexagon:defconfig) Guenter Roeck
2015-10-15 17:28 ` Richard Kuo
2015-10-15 18:05 ` Richard Kuo
2015-10-17 23:24   ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).