From: Greg KH <gregkh@linuxfoundation.org>
To: Sheng Yong <shengyong1@huawei.com>
Cc: stable@vger.kernel.org, jasowang@redhat.com
Subject: Re: [PATCH for 3.10-stable] virtio-net: drop NETIF_F_FRAGLIST
Date: Fri, 6 Nov 2015 10:55:24 -0800 [thread overview]
Message-ID: <20151106185524.GA32467@kroah.com> (raw)
In-Reply-To: <1445910653-174955-1-git-send-email-shengyong1@huawei.com>
On Tue, Oct 27, 2015 at 01:50:53AM +0000, Sheng Yong wrote:
> From: Jason Wang <jasowang@redhat.com>
>
> commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39 upstream.
>
> virtio declares support for NETIF_F_FRAGLIST, but assumes
> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
> always true with a fraglist.
>
> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
> the sg array, leading to memory corruption.
>
> Drop NETIF_F_FRAGLIST so we only get what we can handle.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This patch isn't in any stable tree, why just add it to 3.10? What
about all of the other ones?
thanks,
greg k-h
next prev parent reply other threads:[~2015-11-06 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 1:50 [PATCH for 3.10-stable] virtio-net: drop NETIF_F_FRAGLIST Sheng Yong
2015-11-06 18:55 ` Greg KH [this message]
2015-11-07 2:46 ` Sheng Yong
2015-11-14 16:50 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106185524.GA32467@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=shengyong1@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).