From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:36489 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbbKKWZT (ORCPT ); Wed, 11 Nov 2015 17:25:19 -0500 Date: Wed, 11 Nov 2015 22:25:15 +0000 From: Luis Henriques To: Jiri Slaby Cc: stable@vger.kernel.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Nick Bowler , Jani Nikula Subject: Re: [patch added to the 3.12 stable tree] drm/i915: Restore lost DPLL register write on gen2-4 Message-ID: <20151111222515.GA15443@charon> References: <1447070198-11171-1-git-send-email-jslaby@suse.cz> <1447070198-11171-3-git-send-email-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1447070198-11171-3-git-send-email-jslaby@suse.cz> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Nov 09, 2015 at 12:56:24PM +0100, Jiri Slaby wrote: > From: Ville Syrj�l� > > This patch has been added to the 3.12 stable tree. If you have any > objections, please let us know. > > =============== > > commit 8e7a65aa70bcc1235a44e40ae0da5056525fe081 upstream. > > We accidentally lost the initial DPLL register write in > 1c4e02746147 drm/i915: Fix DVO 2x clock enable on 830M > > The "three times for luck" hack probably saved us from a total > disaster. But anyway, bring the initial write back so that the > code actually makes some sense. > > Reported-and-tested-by: Nick Bowler > References: http://mid.gmane.org/CAN_QmVyMaArxYgEcVVsGvsMo7-6ohZr8HmF5VhkkL4i9KOmrhw@mail.gmail.com > Cc: Nick Bowler > Signed-off-by: Ville Syrj�l� > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > Signed-off-by: Jiri Slaby > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 37a9d3c89feb..8af80f5fe210 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1379,6 +1379,8 @@ static void i9xx_enable_pll(struct intel_crtc *crtc) > > I915_WRITE(reg, dpll); > > + I915_WRITE(reg, dpll); > + I don't think 3.12 actually needs this patch as it does not contain commit 1c4e02746147, which deleted the I915_WRITE(). Cheers, -- Lu�s > /* Wait for the clocks to stabilize. */ > POSTING_READ(reg); > udelay(150); > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html