From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f171.google.com ([209.85.217.171]:33386 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbbKPLqI (ORCPT ); Mon, 16 Nov 2015 06:46:08 -0500 Date: Mon, 16 Nov 2015 12:46:28 +0100 From: Johan Hovold To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Johan Hovold , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem Message-ID: <20151116114628.GB6627@localhost> References: <1446336821-15081-1-git-send-email-bjorn@mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446336821-15081-1-git-send-email-bjorn@mork.no> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Nov 01, 2015 at 01:13:41AM +0100, Bj�rn Mork wrote: > The DEVICE_HWI type was added under the faulty assumption that Huawei > devices based on Qualcomm chipsets and firmware use the static USB > interface numbering known from Gobi devices. But this model does > not apply to Huawei devices like the HP branded lt4112 (Huawei me906e). > Huawei firmwares will dynamically assign interface numbers. Functions > are renumbered when the firmware is reconfigured. > > Fix by changing the DEVICE_HWI type to use a simplified version > of Huawei's subclass + protocol scheme: Blacklisting known network > interface combinations and assuming the rest are serial. > > Reported-and-tested-by: Muri Nicanor > Tested-by: Martin Hauke > Cc: > Fixes: e7181d005e84 ("USB: qcserial: Add support for HP lt4112 LTE/HSPA+ Gobi 4G Modem") > Signed-off-by: Bj�rn Mork This one does not apply to 4.4-rc1. Could you respin and also fix that checkpatch long-line warning? Thanks, Johan