From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:34685 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbbK3TmZ (ORCPT ); Mon, 30 Nov 2015 14:42:25 -0500 Date: Mon, 30 Nov 2015 11:42:22 -0800 From: Brian Norris To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List , Stable Subject: Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition Message-ID: <20151130194222.GH64635@google.com> References: <1448525104-20101-1-git-send-email-zajec5@gmail.com> <20151127223340.GB19615@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Sat, Nov 28, 2015 at 03:05:26PM +0100, Rafał Miłecki wrote: > On 27 November 2015 at 23:33, Brian Norris wrote: > > On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote: > >> On 26 November 2015 at 09:05, Rafał Miłecki wrote: > >> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor") > > > > I'm not 100% sure, but I thought I recall the -stable folks picking up > > for-linus commits just based on the 'Fixes:' tags. I feel like that > > isn't always ideal, though. > > I'm confused. Do you mean I shouldn't include it? No, the 'Fixes' usage is fine. I'm just not clear what importance is placed on it by others. > Do you have a reference to more detailed Fixes usage? All I found is > info in Documentation/SubmittingPatches: > > If your patch fixes a bug in a specific commit, e.g. you found an issue using > > git-bisect, please use the 'Fixes:' tag > I think 'Fixes' usage is OK in this case. I don't have any better reference. Perhaps I'm completely mistaken, and 'Fixes' is never taken as the sole source of for-stable annotation. Brian