stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Filipe Manana <fdmanana@suse.com>
Cc: derek@valedon.co.uk, floyd.net@gmail.com, flux-btrfs@inside.org,
	mail@eliasprobst.eu, malte@tnxip.de, quwenruo@cn.fujitsu.com,
	stephane_btrfs@lesimple.fr, stable@vger.kernel.org, clm@fb.com
Subject: Re: FAILED: patch "[PATCH] Btrfs: fix regression running delayed references when using" failed to apply to 4.2-stable tree
Date: Sat, 12 Dec 2015 11:57:49 -0800	[thread overview]
Message-ID: <20151212195749.GA10064@kroah.com> (raw)
In-Reply-To: <566C2FEA.2060409@suse.com>

On Sat, Dec 12, 2015 at 02:32:10PM +0000, Filipe Manana wrote:
> 
> 
> On 12/11/2015 04:54 PM, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 4.2-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> 
> Greg, please find attached a version of the patch that applies against
> 4.2.7.

This patch breaks the build:

fs/btrfs/delayed-ref.c: In function ‘merge_ref’:
fs/btrfs/delayed-ref.c:223:38: error: ‘struct btrfs_delayed_ref_node’ has no mem
ber named ‘no_quota’
   if (next->type != ref->type || next->no_quota != ref->no_quota)
                                      ^
fs/btrfs/delayed-ref.c:223:55: error: ‘struct btrfs_delayed_ref_node’ has no mem
ber named ‘no_quota’
   if (next->type != ref->type || next->no_quota != ref->no_quota)
                                                       ^
fs/btrfs/delayed-ref.c: At top level:
fs/btrfs/delayed-ref.c:313:13: error: redefinition of ‘merge_ref’
 static bool merge_ref(struct btrfs_trans_handle *trans,
             ^
fs/btrfs/delayed-ref.c:200:13: note: previous definition of ‘merge_ref’ was here
 static bool merge_ref(struct btrfs_trans_handle *trans,
             ^
fs/btrfs/delayed-ref.c:380:6: error: redefinition of ‘btrfs_merge_delayed_refs’
 void btrfs_merge_delayed_refs(struct btrfs_trans_handle *trans,
      ^
fs/btrfs/delayed-ref.c:267:6: note: previous definition of ‘btrfs_merge_delayed_refs’ was here
 void btrfs_merge_delayed_refs(struct btrfs_trans_handle *trans,
      ^

So I'm going to have to drop it, sorry.

greg k-h

  reply	other threads:[~2015-12-12 19:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 16:54 FAILED: patch "[PATCH] Btrfs: fix regression running delayed references when using" failed to apply to 4.2-stable tree gregkh
2015-12-12 14:32 ` Filipe Manana
2015-12-12 19:57   ` Greg KH [this message]
2015-12-12 20:03     ` Greg KH
2015-12-12 21:35       ` Filipe Manana
2015-12-12 21:43         ` Greg KH
2015-12-12 22:02           ` Filipe Manana
2015-12-12 23:17             ` Filipe Manana
2015-12-13  3:47               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151212195749.GA10064@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=clm@fb.com \
    --cc=derek@valedon.co.uk \
    --cc=fdmanana@suse.com \
    --cc=floyd.net@gmail.com \
    --cc=flux-btrfs@inside.org \
    --cc=mail@eliasprobst.eu \
    --cc=malte@tnxip.de \
    --cc=quwenruo@cn.fujitsu.com \
    --cc=stable@vger.kernel.org \
    --cc=stephane_btrfs@lesimple.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).