From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48664 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903AbbL3BrN (ORCPT ); Tue, 29 Dec 2015 20:47:13 -0500 Date: Tue, 29 Dec 2015 17:46:51 -0800 From: Greg Kroah-Hartman To: Lu Baolu Cc: Oliver Neukum , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Jian Qiang , stable@vger.kernel.org Subject: Re: [PATCH v2 1/1] usb: cdc-acm: handle unlinked urb in acm read callback Message-ID: <20151230014651.GA19447@kroah.com> References: <1451436121-3089-1-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451436121-3089-1-git-send-email-baolu.lu@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 30, 2015 at 08:42:01AM +0800, Lu Baolu wrote: > In current acm driver, the bulk-in callback function ignores the > URBs unlinked in usb core. > > This causes unexpected data loss in some cases. For example, > runtime suspend entry will unlinked all urbs and set urb->status > to -ENOENT even those urbs might have data not processed yet. > Hence, data loss occurs. > > This patch lets bulk-in callback function handle unlinked urbs > to avoid data loss. > > Signed-off-by: Tang Jian Qiang > Signed-off-by: Lu Baolu > Cc: stable@vger.kernel.org > Acked-by: Oliver Neukum > --- > drivers/usb/class/cdc-acm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) What changed in v2? Please always document that below the --- line.