From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:43827 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756701AbcAONXW convert rfc822-to-8bit (ORCPT ); Fri, 15 Jan 2016 08:23:22 -0500 Date: Fri, 15 Jan 2016 14:23:19 +0100 From: Jean Delvare To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Andy Lutomirski , Jean Delvare , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables Message-ID: <20160115142319.51f79994@endymion.delvare> In-Reply-To: <20160114095204.GA5473@eudyptula.hq.kempniu.pl> References: <119170b95d373bc943eb4f16818239bac9fa6c59.1451832667.git.luto@kernel.org> <20160112142538.GB11560@pali> <20160114095204.GA5473@eudyptula.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Thu, 14 Jan 2016 10:52:04 +0100, Michał Kępień wrote: > > > Hi Andy, I looked at this patch, but I think some people from -mm or DMI > > > code should look at it as it is memory problem... We also has one in > > > dell-laptop.ko (wrong API usage) and so -mm people could know it better. > > > There are at least two platform drivers (dell-wmi and dell-laptop) > > that don't play well with the current interface. This patch is > > intended to fix one of them. > > Pali, Andy, > > Could you point out the exact place where dell-laptop errs? AFAICT, it > only has one use of dmi_walk(), the callback there calls > parse_da_table(), which does the right thing, i.e. krealloc()'ing memory > and then memcpy()'ing table contents there... FWIW I can't see any problem with dell-laptop either. -- Jean Delvare SUSE L3 Support