From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:55393 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751892AbcATO5m (ORCPT <rfc822;stable@vger.kernel.org>);
	Wed, 20 Jan 2016 09:57:42 -0500
Date: Wed, 20 Jan 2016 14:57:40 +0000
From: Keith Busch <keith.busch@intel.com>
To: Wenbo Wang <mail_weber_wang@163.com>
Cc: axboe@fb.com, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org, wenwei.tao@memblaze.com,
	stable@vger.kernel.org, Wenbo Wang <wenbo.wang@memblaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Message-ID: <20160120145740.GA30512@localhost.localdomain>
References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
> From: Wenbo Wang <wenbo.wang@memblaze.com>
> 
> During reset process, the nvme_dev->bar (ioremapped) may change,
> so nvmeq->q_db shall be also updated by nvme_init_queue().
> 
> Currently nvmeq irq is enabled before queue init, so a spurious
> interrupt triggered nvme_process_cq may access nvmeq->q_db just
> before it is updated, this could cause kernel panic.
> 
> Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
> Reviewed-by: Wenwei Tao <wenwei.tao@memblaze.com>

Looks good, thanks for the fix.

Acked-by: Keith Busch <keith.busch@intel.com>